Support unix domain sockets in fetch() by Jarred-Sumner · Pull Request #9097 · oven-sh/bun

Jarred-Sumner · 2024-02-25T03:57:51Z

What does this PR do?

This adds an option "unix" to fetch that lets you provide a path to a unix domain socket. I'm not sure about this API in particular, but this needs to exist somehow

How did you verify your code works?

Tests in fetch.unix.test.ts

github-actions · 2024-02-25T04:23:46Z

❌ @Jarred-Sumner 1 files with test failures on bun-darwin-aarch64:

test/js/third_party/prisma/prisma.test.ts 2 failing

View test output

^{#6143d63c685fb80d3c93ed915cccb8dd2846a7a6}

github-actions · 2024-02-25T04:28:03Z

❌ @Jarred-Sumner 2 files with test failures on linux-x64:

test/js/third_party/prisma/prisma.test.ts 1 failing
test/js/web/fetch/fetch.test.ts 1 failing

View test output

^{#6143d63c685fb80d3c93ed915cccb8dd2846a7a6}

github-actions · 2024-02-25T04:28:31Z

❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline:

test/cli/install/bun-install.test.ts 9 failing
test/cli/install/registry/bun-install-registry.test.ts 7 failing
test/js/bun/shell/leak.test.ts 1 failing
test/js/third_party/prisma/prisma.test.ts 1 failing

View test output

^{#6143d63c685fb80d3c93ed915cccb8dd2846a7a6}

argosphil · 2024-02-25T07:23:29Z

Can we keep the naming consistent between Bun.serve (which uses unix) and fetch?

gvilums · 2024-03-05T10:29:10Z

Can we keep the naming consistent between Bun.serve (which uses unix) and fetch?

changed to use unix in fetch

github-actions · 2024-03-05T10:58:17Z

❌ @Jarred-Sumner 1 files with test failures on bun-darwin-x64:

test/js/third_party/prisma/prisma.test.ts 2 failing

View test output

^{#6143d63c685fb80d3c93ed915cccb8dd2846a7a6}

github-actions · 2024-03-05T11:06:39Z

❌🪟 @Jarred-Sumner, there are 12 test regressions on Windows x86_64

test\cli\install\bun-upgrade.test.ts
test\cli\run\as-node.test.ts
test\cli\run\transpiler-cache.test.ts
test\js\bun\dns\resolve-dns.test.ts
test\js\bun\http\fetch-file-upload.test.ts
test\js\bun\http\bun-server.test.ts
test\js\bun\shell\shelloutput.test.ts
test\js\bun\shell\throw.test.ts
test\js\node\dns\node-dns.test.js
test\js\node\process\process-args.test.js
test\js\web\fetch\body-stream-excess.test.ts
test\js\web\fetch\body-stream.test.ts

Full Test Output

cirospaciari

some comments

cirospaciari · 2024-03-05T17:49:04Z

+            return try this.context(is_ssl).connectSocket(client, client.unix_socket_path);
+        }
+
        if (client.http_proxy) |url| {


should we error on Bun__fetch if we try to use http_proxy + unix socket?

Yeah we probably should

we also need a test for this case

cirospaciari

one comment and test/js/node/stream/node-stream.test.js (SIGTERM) on bun-darwin-aarch64

Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>

Jarred-Sumner · 2024-03-06T22:11:59Z

The node-stream test is a flaky one, I think unrelated to these changes

Jarred-Sumner · 2024-03-06T22:12:36Z

Please add a test for this:

should we error on Bun__fetch if we try to use http_proxy + unix socket?

Support unix domain sockets in fetch()

b9e0016

gvilums and others added 2 commits March 5, 2024 11:21

rename to 'socket' to 'unix', add test

6b20bae

Merge branch 'main' into jarred/unix-domain

7a95935

gvilums marked this pull request as ready for review March 5, 2024 10:22

enable keepalive on unix socket fetch

832391f

gvilums requested a review from cirospaciari March 5, 2024 12:10

cirospaciari requested changes Mar 5, 2024

View reviewed changes

gvilums and others added 6 commits March 6, 2024 13:09

make ownership of unix_socket_path clear, refactor http.zig a bit

e4b2af5

[autofix.ci] apply automated fixes

dd346c9

add fetch unix redirect test, fix crash

184488e

[autofix.ci] apply automated fixes

0fe7703

fix fetch redirect from unix to non-unix

e3f397f

disable keepalive for unix sockets (for now) so we don't leak them

7afffd8

gvilums requested a review from cirospaciari March 6, 2024 13:50

cirospaciari requested changes Mar 6, 2024

View reviewed changes

Comment thread test/js/web/fetch/fetch.unix.test.ts Outdated

Update test/js/web/fetch/fetch.unix.test.ts

c0f6e34

Co-authored-by: Ciro Spaciari <ciro.spaciari@gmail.com>

Jarred-Sumner merged commit a669262 into main Mar 6, 2024

Jarred-Sumner deleted the jarred/unix-domain branch March 6, 2024 22:12

This was referenced Aug 14, 2026

fetch: follow same-origin redirects over the unix socket #38394

Open

fetch: ignore http_proxy/https_proxy when the request uses a unix socket #38420

Closed

Conversation

Jarred-Sumner commented Feb 25, 2024 • edited by gvilums Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

How did you verify your code works?

Uh oh!

github-actions Bot commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Feb 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

argosphil commented Feb 25, 2024

Uh oh!

gvilums commented Mar 5, 2024

Uh oh!

github-actions Bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌🪟 @Jarred-Sumner, there are 12 test regressions on Windows x86_64

Uh oh!

cirospaciari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cirospaciari Mar 5, 2024

Choose a reason for hiding this comment

Uh oh!

gvilums Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

gvilums Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

cirospaciari Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cirospaciari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Jarred-Sumner commented Mar 6, 2024

Uh oh!

Jarred-Sumner commented Mar 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Jarred-Sumner commented Feb 25, 2024 •

edited by gvilums

Loading

github-actions Bot commented Feb 25, 2024 •

edited

Loading

github-actions Bot commented Feb 25, 2024 •

edited

Loading

github-actions Bot commented Feb 25, 2024 •

edited

Loading

github-actions Bot commented Mar 5, 2024 •

edited

Loading

github-actions Bot commented Mar 5, 2024 •

edited

Loading