Repository navigation
shell: Allow duplicating output fds (e.g. 2>&1) - #9004
Merged
Merged
Conversation
Contributor
|
✅ test failures on bun-darwin-aarch64 have been resolved. |
Contributor
|
❌ @zackradisic 1 files with test failures on linux-x64:
|
Contributor
|
❌ @zackradisic 2 files with test failures on linux-x64-baseline:
|
Contributor
❌🪟 @zackradisic, there are 18 test regressions on Windows x86_64
|
| const std = @import("std"); | ||
| const bun = @import("root").bun; | ||
|
|
||
| pub fn search(str: anytype, needle: anytype) ?usize {} |
Collaborator
|
Can you add this to the docs to explain its supported? Along with stdin redirection |
Contributor
|
❌ @zackradisic 1 files with test failures on bun-darwin-x64:
|
| - `Bun.file(path)`, `Bun.file(fd)` (reads from the file) | ||
| - `Response` (reads from the body) | ||
|
|
||
| ### To/From Files |
Collaborator
There was a problem hiding this comment.
Maybe a section on Redirects?
And then
Redirecting stdout → file
Redirecting stderr → file
Redirecting stdin ← file
Redirecting stdout → stderr
Redirecting stdout ← stderr
Collaborator
There was a problem hiding this comment.
basically, people might not immediately make the mental leap that stdout and stderr are a "file"
Also, we could do buffers in there too.
| @@ -1463,6 +1465,7 @@ pub fn NewShellSubprocess(comptime EventLoopKind: JSC.EventLoopKind, comptime Sh | |||
| spawn_args.stdio[2].setUpChildIoPosixSpawn( | |||
| &actions, | |||
| stderr_pipe, | |||
Collaborator
There was a problem hiding this comment.
stderr_pipe,
stderr_pipe
|
|
||
| await TestBuilder.command`echo foo bar > file.txt; cat < file.txt`.ensureTempDir().stdout("foo bar\n").run(); | ||
|
|
||
| await TestBuilder.command`BUN_DEBUG_QUIET_LOGS=1 ${BUN} -e ${"console.log('Stdout'); console.error('Stderr')"} 2>&1` |
Collaborator
There was a problem hiding this comment.
you can remove BUN_DEBUG_QUIET_LOGS from these, it should do that automatically now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables support for the "Duplicating an Output File Descriptor" syntax (e.g.
2>&1)Only the stdout/stderr fds are supported right now. So you can redirect stderr to stdout
2>&1, or redirect stdout to stderr1>&2How did you verify your code works?
Zig files changed:
bun-debug test test-file-name.test)