Skip to content

docs: remove unncessary use of async - #8341

Merged
paperclover merged 1 commit into
oven-sh:mainfrom
DaleSeo:patch-4
Jan 23, 2024
Merged

paperclover merged 1 commit into
oven-sh:mainfrom
DaleSeo:patch-4

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Jan 22, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

The async keyword is unnecessary and could be misleading because there is no await calls in the test functions.

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@paperclover

Copy link
Copy Markdown
Contributor

wonder if we should have an example using async and await since it is supported

@DaleSeo

DaleSeo commented Jan 22, 2024

Copy link
Copy Markdown
Contributor Author

@paperdave I found some examples using async on https://bun.sh/docs/test/writing#basic-usage. I have no opinions but I guess this is sufficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants