Repository navigation
Upgrade uWebSockets & usockets - #8164
Merged
Merged
Conversation
Contributor
|
❌ @Jarred-Sumner 2 files with test failures on bun-darwin-aarch64:
|
Contributor
❌🪟 @Jarred-Sumner, there are 2 test regressions on Windows x86_64
|
Contributor
|
❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline: |
Contributor
|
❌ @Jarred-Sumner 3 files with test failures on linux-x64: |
Contributor
|
❌ @Jarred-Sumner 6 files with test failures on bun-darwin-x64:
|
| /* This guy really has only 30 bits since we reserve two highest bits to chunked encoding parsing state */ | ||
| unsigned int remainingStreamingBytes = 0; | ||
| /* This guy really has only 30 bits since we reserve two highest bits to chunked encoding parsing state */ | ||
| uint64_t remainingStreamingBytes = 0; |
Member
There was a problem hiding this comment.
this comment is not true anymore because now we are using up to 18 number of 9s
| if (!CONSUME_MINIMALLY) | ||
| { | ||
| unsigned int emittable = std::min<unsigned int>(remainingStreamingBytes, length); | ||
| unsigned int emittable = (unsigned int) std::min<uint64_t>(remainingStreamingBytes, length); |
Member
There was a problem hiding this comment.
what happens when we send like a 5gb in one chunk now?
| static uint64_t toUnsignedInteger(std::string_view str) { | ||
| /* We assume at least 64-bit integer giving us safely 999999999999999999 (18 number of 9s) */ | ||
| if (str.length() > 18) { | ||
| return UINT_MAX; |
Member
There was a problem hiding this comment.
999999999999999999 is bigger than UINT_MAX now we probably wanna ULONG_MAX now
Contributor
|
@Jarred-Sumner Please look at CI checks before merging. This broke windows 
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This cherry-picks the following commits:
How did you verify your code works?
Existing tests