Skip to content

UDP support - #7271

Merged
gvilums merged 70 commits into
mainfrom
udp
Apr 26, 2024
Merged

gvilums merged 70 commits into
mainfrom
udp

Conversation

@Electroid

@Electroid Electroid commented Nov 22, 2023 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Issues

TODO

  • Diff needs to be cleaned up, since files in packages/bun-usockets were re-formatted.
  • Added support for $variable in test.each.
  • Fixed issue where Bun.spawn would remove empty arguments from cmd .
  • Update documentation for node:dgram
  • Update documentation for Bun's UDP API
  • Decide on final Bun API (still work-in-progress)

How did you verify your code works?

I wrote automated tests.

@Electroid
Electroid marked this pull request as ready for review November 22, 2023 21:46
@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

this doesn't implement dgram yet

@github-actions

github-actions Bot commented Nov 22, 2023 •

Copy link
Copy Markdown
Contributor

❌ @Electroid 5 files with test failures on bun-darwin-aarch64:

  • test/integration/next/default-pages-dir/test/dev-server.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/bun/udp/udp.test.ts
  • test/js/bun/util/which.test.ts

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

@github-actions

github-actions Bot commented Nov 22, 2023 •

Copy link
Copy Markdown
Contributor

❌ @Electroid 7 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/udp/udp.test.ts
  • test/js/bun/util/filesink.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

@github-actions

github-actions Bot commented Nov 23, 2023 •

Copy link
Copy Markdown
Contributor

❌ @Electroid 2 files with test failures on linux-x64:

  • test/js/bun/udp/udp.test.ts
  • test/js/third_party/postgres/postgres.test.ts

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

@github-actions

github-actions Bot commented Nov 23, 2023 •

Copy link
Copy Markdown
Contributor

❌ @Electroid 2 files with test failures on linux-x64-baseline:

  • test/js/bun/udp/udp.test.ts
  • test/js/third_party/postgres/postgres.test.ts

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

@github-actions

Copy link
Copy Markdown
Contributor

❌ @Electroid 8 files with test failures on bun-darwin-x64:

  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/bun/spawn/spawn-streaming-stdout.test.ts
  • test/js/bun/udp/udp.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#9cb7ee2130ac3c1b357d664bf359af709426935a

Comment thread src/bun.js/api/bun/udp_socket.zig Outdated
@gvilums
gvilums merged commit 589f941 into main Apr 26, 2024
@gvilums
gvilums deleted the udp branch April 26, 2024 22:25
@defaultkavy

Copy link
Copy Markdown

Thank you very much for completing this🙏

@benjamingwynn

Copy link
Copy Markdown

For my own reference, advanced dgram methods are covered in issue #10381

@RadhiRasho

Copy link
Copy Markdown
Contributor

This might just be me, but it would seem like the bun-types changes never made it out/weren't bundled correctly. I've tried every way I can to get the latest and I'm on the latest version of Bun:
image

I've also set the version of the @types/bun package to be the latest and cleared the pm cache a few times using bun pm cache rm.

This is all in a simple bun init project and is easily reproducible.

@RadhiRasho

Copy link
Copy Markdown
Contributor

This might just be me, but it would seem like the bun-types changes never made it out/weren't bundled correctly. I've tried every way I can to get the latest and I'm on the latest version of Bun: image

I've also set the version of the @types/bun package to be the latest and cleared the pm cache a few times using bun pm cache rm.

This is all in a simple bun init project and is easily reproducible.

Ignore, seems to have been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement $var interpolation in test.each Implement dgram

6 participants