Repository navigation
Make node:fs load lazily - #7021
Closed
Jarred-Sumner wants to merge 1 commit into
Closed
Jarred-Sumner wants to merge 1 commit into
Jarred-Sumner wants to merge 1 commit into
Conversation
Contributor
|
❌ @Jarred-Sumner 10 files with test failures on bun-darwin-aarch64:
|
Contributor
|
❌ @Jarred-Sumner 8 files with test failures on linux-x64-baseline:
|
Contributor
|
❌ @Jarred-Sumner 9 files with test failures on linux-x64:
|
Contributor
|
❌ @Jarred-Sumner 12 files with test failures on bun-darwin-x64-baseline:
|
Contributor
|
❌ @Jarred-Sumner 13 files with test failures on bun-darwin-x64:
|
Jarred-Sumner
force-pushed
the
jarred/fs-lazy
branch
from
November 10, 2023 07:43
de78316 to
f7282a4
Compare
Jarred-Sumner
marked this pull request as draft
November 10, 2023 09:09
This was referenced Nov 28, 2023
This was referenced Apr 30, 2024
This was referenced May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes
node:fsload modules lazily. This also moves someSymbol.forusages into a sharedinternal/symbolsmodule so we don't expose these APIs unintentionally.After:
Before:
How did you verify your code works?
Existing tests