Repository navigation
Create share image for social media - #629
Merged
Merged
Conversation
FinnRG
suggested changes
Jul 12, 2022
FinnRG
approved these changes
Jul 12, 2022
Contributor
|
@gabrnunes Could you resolve the merge conflicts? |
Contributor
Author
|
Done! @FinnRG |
1 task
amritk
pushed a commit
to amritk/bun
that referenced
this pull request
Aug 21, 2026
One of the two lsquic patches fixes a real defect and now has an issue to point at. The other has no issue on purpose, and a patch with no link reads as an oversight unless the file says why: the duplicate setting id is an interaction with our own node-quic-accessors.patch rather than anything upstream got wrong, and which WebTransport draft lsquic targets is its call. The more useful half is the expiry date. Upstream's draft oven-sh#629 does not fix the flags bug, it deletes the code that has it -- the accessors, both flags, and the LSQUIC_WEBTRANSPORT_SERVER_SUPPORT guard we compile with -- and replaces the lot with a session/switch-stream abstraction. Whoever bumps lsquic past it will find these patches no longer apply and reasonably assume a rebase is what is wanted. It is not: it is a rewrite of our side, and better to learn that here than from the reject files.
amritk
pushed a commit
to amritk/bun
that referenced
this pull request
Aug 31, 2026
litespeedtech/lsquic#674 was fixed by litespeedtech/lsquic#676 and released in 4.9.4, so the vendored patch is temporary in the ordinary sense: it dies at the next lsquic bump rather than at the oven-sh#629 rewrite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that the landing page doesn't have a image when someone share in Twitter/Facebook/LinkedIn. I created an image and put in the code.