Skip to content

hono example with typescript - #577

Merged
FinnRG merged 13 commits into
oven-sh:mainfrom
Jesse-Lucas1996:hono-template
Jul 12, 2022
Merged

FinnRG merged 13 commits into
oven-sh:mainfrom
Jesse-Lucas1996:hono-template

Conversation

@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor

hono example with typescript

@xhyrom xhyrom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete .gitignore, it's not in any example.

@Jesse-Lucas1996
Jesse-Lucas1996 requested a review from xhyrom July 11, 2022 13:32
@xhyrom

xhyrom commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

why are you adding dom to lib?

@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor Author

That's a good question, brain is fried

@xhyrom xhyrom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

port variable is defined

Comment thread examples/hono/src/index.ts Outdated
Jesse-Lucas1996 and others added 2 commits July 11, 2022 23:05
Co-authored-by: Hyro <generalkubo@gmail.com>
@Jesse-Lucas1996
Jesse-Lucas1996 requested a review from xhyrom July 11, 2022 17:00
@FinnRG FinnRG linked an issue Jul 11, 2022 that may be closed by this pull request
@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor Author

Is this good to get merged in?

@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor Author

Sweet, just merge in when can. I don't have write access

@FinnRG

FinnRG commented Jul 12, 2022 •

Copy link
Copy Markdown
Contributor

@Jesse-Lucas1996 When I try to run bun run start, I get the following error (even if I specify the PORT env variable):

$ cd src && bun run index.ts
2 | 
3 | const app = new Hono();
4 | const home = app.get("/", (c) => {
5 |   return c.json({ message: "Hello World!" });
6 | });
7 | console.log(`Running at http://localhost:${port}`);
                                              ^
 ReferenceError: Can't find variable: port
      at /home/fg/Projects/hono-template/examples/hono/src/index.ts:7:43
Script error "start" exited with 1 status

@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor Author

Ah yes I know the issue will fix soon

@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor Author

@FinnRG I accidently removed code in update. All good to go now

Comment thread examples/hono/package.json Outdated
Comment thread examples/hono/readme.md Outdated
@Jesse-Lucas1996

Copy link
Copy Markdown
Contributor Author

@FinnRG and done :) nit pick away!! I love learning better or more refined ways

@FinnRG
FinnRG merged commit a63a0cc into oven-sh:main Jul 12, 2022
@FinnRG

FinnRG commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: Hono Template

3 participants