hono example with typescript - #577
Merged
Merged
Conversation
xhyrom
suggested changes
Jul 11, 2022
xhyrom
left a comment
Contributor
There was a problem hiding this comment.
Please delete .gitignore, it's not in any example.
Contributor
|
why are you adding dom to lib? |
Contributor
Author
|
That's a good question, brain is fried |
Co-authored-by: Hyro <generalkubo@gmail.com>
Closed
Contributor
Author
|
Is this good to get merged in? |
xhyrom
approved these changes
Jul 12, 2022
Contributor
Author
|
Sweet, just merge in when can. I don't have write access |
Contributor
|
@Jesse-Lucas1996 When I try to run |
Contributor
Author
|
Ah yes I know the issue will fix soon |
Contributor
Author
|
@FinnRG I accidently removed code in update. All good to go now |
FinnRG
suggested changes
Jul 12, 2022
FinnRG
suggested changes
Jul 12, 2022
Contributor
Author
|
@FinnRG and done :) nit pick away!! I love learning better or more refined ways |
FinnRG
approved these changes
Jul 12, 2022
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hono example with typescript