Repository navigation

Remove 126 `unsafe` blocks from the core crates, the resolver and the package manager - #47414

Open

dylan-conway wants to merge 54 commits into

mainfrom

claude/remove-unsafe-batch-7

Open

Remove 126 `unsafe` blocks from the core crates, the resolver and the package manager#47414
dylan-conway wants to merge 54 commits into
mainfrom
claude/remove-unsafe-batch-7

Commits on Oct 29, 2026
- toml: the parser keeps tables and arrays as `StoreRef`
  
  claude
  and
  dylan-conway
  committed
  c1ca51f
- bun_core: remove `boxed_zeroed_unchecked`, `ZStr::boxed` and `OptionsEnvArg for Box<ZStr>`
  
  claude
  and
  dylan-conway
  committed
  59c10e2
- xml: `Unit::from_u16` and `Unit::from_bytes` instead of casts
  
  claude
  and
  dylan-conway
  committed
  a044535
- crash_handler: `UNSUPPORTED_UV_FUNCTION` holds the name's bytes
  
  claude
  and
  dylan-conway
  committed
  cc2d57e
- xml_index: `StructuralIndex::seek` and `at` read the window with `get`
  
  claude
  and
  dylan-conway
  committed
  2b35613
- collections: `HiveSlot` borrows its hive
  
  claude
  and
  dylan-conway
  committed
  3e7d3c9
- bun_core: `vec::extend_from_fn` is `Vec::extend`
  
  claude
  and
  dylan-conway
  committed
  dee9080
- fmt: the shared temp buffer is an `Option<Box>`
  
  claude
  and
  dylan-conway
  committed
  a0c8cff
- SmolStr: `Inlined::all_chars` views the `u128` with `bytes_of_mut`
  
  claude
  and
  dylan-conway
  committed
  ebc36f0
- bun_core: `impl io::Write for Writer` calls the inherent methods
  
  claude
  and
  dylan-conway
  committed
  a10a006
- atomic_cell: `unreachable!()` for the widths that `Atom` excludes
  
  claude
  and
  dylan-conway
  committed
  5e10673
- highway: `memmem` subtracts addresses
  
  claude
  and
  dylan-conway
  committed
  166a6d2
- Check constant strings at compile time instead of `from_utf8_unchecked`
  
  claude
  and
  dylan-conway
  committed
  a3c759b
- Call `gettid`, `getpid`, `alarm`, `_exit` and `raise` as `safe fn`
  
  claude
  and
  dylan-conway
  committed
  211f7e9
- bun_core: `fd_path_raw_w` takes `&mut [u16]`
  
  claude
  and
  dylan-conway
  committed
  a920067
- output: `STDOUT_STREAM` and `STDERR_STREAM` are atomics
  
  claude
  and
  dylan-conway
  committed
  27e6eeb
- resolver: `BrowserMapPath::map` is `&'static BrowserMap`
  
  claude
  and
  dylan-conway
  committed
  fe10856
- resolver: keep the slot that `MaybeUninit::write` returns
  
  claude
  and
  dylan-conway
  committed
  8c348de
- resolver: drop three lifetime casts that change nothing
  
  claude
  and
  dylan-conway
  committed
  0270bca
- resolver: `RealFS::read_directory` and `EntryLookup` keep their `'static`
  
  claude
  and
  dylan-conway
  committed
  24176a7
- http: `h3::ClientContext::get_or_create` reads the loop itself
  
  claude
  and
  dylan-conway
  committed
  5980510
- boringssl: `ssl_ctx_setup` takes `&OwnedSslCtx`
  
  claude
  and
  dylan-conway
  committed
  80e3575
- sourcemap: `impl_pod!` for `SyncEntry` and `ObjectBrace`
  
  claude
  and
  dylan-conway
  committed
  6319e52
- sourcemap: `WindowReader<'a>` borrows the stream
  
  claude
  and
  dylan-conway
  committed
  8f2ec5d
- resolver: four `unsafe` blocks that plain borrows replace
  
  claude
  and
  dylan-conway
  committed
  e1644df
- resolver: `package_json` travels as `&'static PackageJSON`
  
  claude
  and
  dylan-conway
  committed
  895e0e0
- resolver: `load_tsconfig` keeps its boxes
  
  claude
  and
  dylan-conway
  committed
  160dad7
- resolver: `BIN_FOLDERS` is initialised at compile time
  
  claude
  and
  dylan-conway
  committed
  00fc417
- standalone_graph: in `inject`, `zname` borrows `zname_owned`
  
  claude
  and
  dylan-conway
  committed
  3a7a349
- sourcemap: `ParsedSourceMap` holds the standalone graph's sources by type
  
  claude
  and
  dylan-conway
  committed
  6bf6c28
- http: `InitOpts::abs_ca_file_name` is a `&'static ZStr`
  
  claude
  and
  dylan-conway
  committed
  4dea31f
- exe_format: `_mh_execute_header` is a `safe static`
  
  claude
  and
  dylan-conway
  committed
  b0116e4
- install: `init` reborrows the `&'static mut DirEntry` it matched on
  
  claude
  and
  dylan-conway
  committed
  91cb2a9
- install: `save_lockfile` uses `progress.root` instead of a stashed node pointer
  
  claude
  and
  dylan-conway
  committed
  2d599ab
- install: drop four raw-pointer and lifetime detours that borrowck does not need
  
  claude
  and
  dylan-conway
  committed
  f55e016
- install: `find_workspace_root_above` borrows `walk.path` for the source path
  
  claude
  and
  dylan-conway
  committed
  dda35a9
- install: `AutoInstaller::path_for_resolution` takes `&mut PathBuffer`
  
  claude
  and
  dylan-conway
  committed
  2b5a192
- install: `NetworkTask` reads its manager through the `ParentRef` it stores
  
  claude
  and
  dylan-conway
  committed
  f14394f
- install: remove three one-line `unsafe` blocks that have a safe spelling
  
  claude
  and
  dylan-conway
  committed
  663b8a5
- install: clear `root_lifecycle_scripts` with a `scopeguard` on `manager`
  
  claude
  and
  dylan-conway
  committed
  129afdb
- semver: delete `query::Group.input`
  
  claude
  and
  dylan-conway
  committed
  0dc4f19
- install: `UpdateRequest.e_string` keeps the `StoreRef` it is made from
  
  claude
  and
  dylan-conway
  committed
  44a3f88
- install: `TarballStream::init` returns a `Box` and `populate_result` is a safe fn
  
  claude
  and
  dylan-conway
  committed
  b1fc886
- install: the Windows hardlink task is passed and reclaimed as a `Box`
  
  claude
  and
  dylan-conway
  committed
  6986eeb
- install: the Windows `Hardlinker` keeps the cwd slice it gets
  
  claude
  and
  dylan-conway
  committed
  ba8ec80
- install: `ROOT_PACKAGE_JSON_PATH` becomes `PackageManager::root_package_json_path`
  
  claude
  and
  dylan-conway
  committed
  f418a47
- install: `Diff::generate` takes `to_update: bool` instead of the update requests
  
  claude
  and
  dylan-conway
  committed
  5dadab2
- install: `Package::parse_from_real_manager` takes `&mut PackageManager`
  
  claude
  and
  dylan-conway
  committed
  a7f1fa0
- install: in `init`, `original_cwd` borrows the boxed copy of the cwd
  
  claude
  and
  dylan-conway
  committed
  12b39ec
- install: remove two pieces of dead code that needed `unsafe`
  
  claude
  and
  dylan-conway
  committed
  e31083d
- xml_index: `seek_refill` calls `at` for every index, as it did
  
  claude
  and
  dylan-conway
  committed
  5d85c2a
- resolver: `EntriesOption::try_entries_mut` returns the listing or the read error
  
  claude
  and
  dylan-conway
  committed
  0ce5584
Commits on Oct 30, 2026
- test: `custom-accessor-reached-computed-key.ir` allows one more member in eleven types
  claude
  committed
  45884ed
- test: record the growth in memory of one shape of build-scaling, as #47329 does
  claude
  committed
  b9d7f3a

Commits

Commits on Oct 29, 2026

Commits on Oct 30, 2026