Skip to content

test: the floor of the ICU version takes a version with more parts than it has #47323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 2 commits into from
Oct 29, 2026
Merged

test: the floor of the ICU version takes a version with more parts than it has #47323

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4b243a
test: the floor of the ICU version takes a version with four parts
Jarred-Sumner Oct 29, 2026
b60fa72
test: compare as many parts of the ICU version as the floor has
Jarred-Sumner Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/js/node/process/process.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,9 @@ it("ICU version does not regress", () => {
if (!min) {
throw new Error(`Unknown platform/arch: ${process.platform}-${process.arch}`);
}
expect(Bun.semver.order(process.versions.icu, min)).toBeGreaterThanOrEqual(0);
// As many parts as the floor has: macOS may report four, and Bun.semver.order reads a missing part as the highest.
const version = process.versions.icu.split(".").slice(0, 2).join(".");
expect(Bun.semver.order(version, min)).toBeGreaterThanOrEqual(0);
});

it("process.versions.icu and process.versions.unicode describe the ICU the process runs with", () => {
Expand Down
Loading