Skip to content

upgrade-webkit: check upstream structured clone changes against Bun's copy #46773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

upgrade-webkit: check upstream structured clone changes against Bun's copy #46773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .claude/commands/upgrade-webkit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,6 @@ To do that:
Things to check for a successful upgrade:

- Did Source/JavaScriptCore/runtime/JSType.h change? The enum values must align with Bun's mirror in src/jsc/JSType.rs.
- Did the structured clone code change (Source/JavaScriptCore/runtime/CloneBase.h, CloneSerializerBase.h, CloneDeserializerBase.h, StructuredCloneTags.h, StructuredCloneTags.cpp, or Source/WebCore/bindings/js/SerializedScriptValue.cpp)? Bun's copy in src/jsc/bindings/webcore/SerializedScriptValue.cpp does not derive from the JSC clone base classes, so the upgrade does not update it. Port each behavior change into that file by hand.
- Were there any changes to the WebCore code generator? If there are C++ compilation errors, check for differences in the generated reference code in vendor/WebKit/Source/WebCore/bindings/scripts/test/JS/
- If the merge touched the fork's .github/workflows, the release tarball names must still match prebuiltSuffix() in scripts/build/deps/webkit.ts
Loading