bindgen: move the stream sinks to a schema and delete `generate-jssink.ts` by dylan-conway · Pull Request #46641 · oven-sh/bun

Delete what the sinks were the last to use, fix the lints and name the sink controller as one

dylan-conway

committed

899e166

bindgen: generate the calls between C++ and Rust as member functions of the class, and move the sink controller onto them

dylan-conway

committed

b9a4c5f

bindgen: give the generated C++ class typed internal fields and member functions with native signatures, and put the sinks' C++ back to main's text or simpler

dylan-conway

committed

33501e7

[autofix.ci] apply automated fixes

autofix-ci[bot]

authored

595b9cc

bindgen: give typed internal fields to C++ alone, pass globalObject to a member only if it needs one, and put the sinks' Rust back to main's text

dylan-conway

committed

4795c83

bindgen: declare the fields of CellClass, as Node's type stripping has no parameter properties

dylan-conway

committed

464c99a

sinks: compile Start::file_sink_from_js only where Bun.file().writer() reads its options

dylan-conway

committed

3f2250f

sinks: put the controller's detach and finalize hooks back on the trait, and name the parameters of generated member functions by position

dylan-conway

committed

85e0ec8

sinks: read the options of Bun.file().writer() where they are used, and restore the comments that still hold

dylan-conway

committed

a6c99ec

test: check the message of a controller's write with a wrong this

dylan-conway

committed

214daeb

Navigation Menu

Repository navigation

bindgen: move the stream sinks to a schema and delete `generate-jssink.ts` - #46641

bindgen: move the stream sinks to a schema and delete `generate-jssink.ts`#46641
dylan-conway merged 12 commits into
mainfrom
claude/bindgen-sinks

Commits on Oct 23, 2026

bindgen: move the stream sinks to a schema and delete `generate-jssink.ts`

[autofix.ci] apply automated fixes

Commits on Oct 24, 2026

Delete what the sinks were the last to use, fix the lints and name the sink controller as one

bindgen: generate the calls between C++ and Rust as member functions of the class, and move the sink controller onto them

bindgen: give the generated C++ class typed internal fields and member functions with native signatures, and put the sinks' C++ back to main's text or simpler

[autofix.ci] apply automated fixes

bindgen: give typed internal fields to C++ alone, pass globalObject to a member only if it needs one, and put the sinks' Rust back to main's text

bindgen: declare the fields of CellClass, as Node's type stripping has no parameter properties

sinks: compile Start::file_sink_from_js only where Bun.file().writer() reads its options

sinks: put the controller's detach and finalize hooks back on the trait, and name the parameters of generated member functions by position

sinks: read the options of Bun.file().writer() where they are used, and restore the comments that still hold

test: check the message of a controller's write with a wrong this