Repository navigation
http, net, tls: consolidate the open fetch, Bun.serve, node:http, node:http2, HTTP/3, node:net and node:tls pull requests #46528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jarred-Sumner
wants to merge
462
commits into
main
Choose a base branch
from
claude/http-consolidated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+111,701
−64,895
Open
Changes from 30 commits
Commits
Show all changes
462 commits
Select commit
Hold shift + click to select a range
5c4c8bf
tls: reset a connection with unsent bytes when its thread ends
claude 0048d8d
spawn: throw when the IPC channel cannot be opened
claude a8da810
socket: the callbacks of a connection outlive a connect() that replac…
claude fda3b09
socket: a send that fails with EPERM fails the write instead of passi…
claude 75991fa
node:tls: a write gets its callback when the socket closes while the …
claude 0bdf5bd
node:net: resume() starts a handle that was stopped while a read was …
claude 9f98ecd
node:net: a socket that connected again ignores the handle of its ear…
claude ee81003
node:net: the timeout of a new connection doesn't count what the prev…
claude 6347f8b
Bun.listen, Bun.connect: a dropped end(data) tail is an error for clo…
claude db19df7
Bun.listen, Bun.connect: wait for the peer's FIN behind the tail of e…
claude 4a7e474
Bun.listen, Bun.connect: records that the TLS layer holds count as th…
claude 1b934b4
node:net: declare that doConnect can return undefined
claude 49cf0e9
node:net: fdIsWriteOnly is a private name
claude 2f6b90f
--hot: a net.Server neither takes over an address nor gives its own up
claude 12bef60
Bun.gc(true): finish pending compilations, which hold the values they…
claude afa9cd4
uws: remove the write_continue bindings that nothing calls
claude 8f92781
socket: the callbacks are rooted from the moment the options are parsed
claude 16e31af
node:http: a body that was whole before its first read isn't dumped u…
claude f3645b0
node:http: a turn without a response is null
claude c117e8a
aot: the connection's members have slots of their own
claude faa503d
node:http: a request is complete after the jobs of its last chunk, wh…
claude 82c810b
Merge remote-tracking branch 'origin/main' into fx/h-pipe
claude c0d979b
fetch, sockets, node:http2, cluster, Bun.serve: fixes from review
claude 97c1e30
aot: one test for a connection that is not known to flow
claude 543a610
aot: the end of a body is queued under the name it has on the full road
claude 48e3985
Merge branch 'main' into claude/http-consolidated
claude ba00436
tls: an SNICallback that selects nothing falls back to addContext() a…
claude 7bafe86
process.stdin: keep Readable's destroy()
claude 26b987e
aot: an upgrade stream takes the sockets a message takes
claude b21eb17
[autofix.ci] apply automated fixes
autofix-ci[bot] 67bfc67
usockets: LIKELY and UNLIKELY compile as C++ on every libc; sockets: …
claude 41d2b31
test: the peer of a lingering socket reads only once end() has returned
claude 16b578b
tls: the OpenSSL default certificates compile on Windows
claude 101d37e
trim: the readers of a body go with Bodies; Bun.serve: cold code that…
claude f308646
kqueue: a write to a unix peer that closed fails with EPIPE, and fetc…
claude b74739d
node:net: loads with any --network-family-autoselection-attempt-timeout
claude 930f69c
test: an http2 stream listens for its reset, and the leak control out…
claude 4eb05c1
ipc: a lost message that carries a handle is answered without an erro…
claude ccb768a
node:http: 'drain' waits for the CRLF that ends a large chunk
claude 68bee65
test: the pipelining tests don't write to a closed connection, and st…
claude 914f3eb
fetch: a stream body waits while the proxy doesn't read
claude f60b579
Merge main into claude/http-consolidated
claude 5845a24
test: the parked handshakes are swept until their peers' FINs have ar…
claude 2668561
test(aot): the process that measures a run doesn't get the environmen…
claude 50f6e76
Merge remote-tracking branch 'origin/main' into fx/h-pipe
claude 7a05829
Bun.serve: set-up and error paths are compiled for size, and /bun:inf…
claude 9a3bfb0
trim: sockets, the transpiler and WebAssembly don't take node:http or…
claude 9e655b6
node:net: a socket that is sent with a write in flight hears how the …
claude 4b556ef
test: three checks that depended on when a collection ran or a close …
claude 47334ee
Merge remote-tracking branch 'origin/main' into fx/h-pipe
claude 08ef045
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude d373d08
SSLContextCache: lend the cache of this thread to a closure
claude e80e4d5
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 9ba1452
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 59b5420
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 96ff812
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 3d633cc
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 5b8f37a
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 252410f
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 1d96bcc
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude ee8e71f
TLS servers: closing an idle connection doesn't wait for the peer's c…
claude 2b90fee
Bun.serve: stop() waits for an idle TLS peer again, closeIdleConnecti…
claude 2814e2c
usockets: an accept batch gets the time that the rest of the loop took
claude a4f92a3
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 75f069b
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude ebf298d
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude f69dc59
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude bc3f347
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude a270131
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 51230a5
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude a629170
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude b69b54a
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 933fd72
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 9833131
event loop: read the mini loop's uws loop before queueing a task
claude bba5211
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 941bebf
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 1e98cbd
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 333bd51
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude e26ce1c
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude ba30e65
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 49690b8
fetch: free a preconnect that is still in flight at exit
claude 4b0fdd9
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 0be572f
body: remove the unused ValueError::reset
claude d7f4d82
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude aa13620
test: the QUIC endpoint socket does not set IP_RECVERR
claude 4be3613
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 9114384
net: remove the poll of a write-only descriptor that stays open after…
claude ec73886
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude b497de3
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 2e76e6c
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 49cafda
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 277d4d9
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 2cacac9
test: ipv6Only asks the server who reached it
claude 99e8f8f
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude cfb76bd
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 4400e4d
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude a67b42b
http2: handle what a transport's write() does to the session, the str…
claude 0702c40
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 00f200d
link: free the working directory before the arms that exit
claude e19f9a6
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude f92b1f5
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 9b20c23
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 10e06c3
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 114b95f
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude bbe7f3f
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude f14a608
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude d17da3b
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude d82a329
event loop: clear the dead stack before immediates run
claude b082977
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude aa5c836
dispatch: count the task tags of both sides of the merge
claude b35068c
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 7f76076
Stop only the Date allocators when the time zone changes
claude e48d3dd
http: parse the response head outside the generic handler
claude f429db3
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 6b706f0
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude ce3888f
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 8baee40
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude e509eaa
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude fb46e7b
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 650eaf7
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude f1872ce
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 9b6a05f
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude d5d7fa6
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude b4a771c
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 8abceee
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 75dd749
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 2dda4e6
http: an empty text/event-stream response is complete at its head
claude 50ee095
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 5fbbe4b
test: run the writeHead termination fixture until it has seen each case
claude 9a4926b
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 81065d9
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 70f1b94
windows_sys: remove unused AF_UNIX
claude 664b393
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 744a7f3
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 0b81a8e
test(http2): wait for the server session's close even if a reset come…
claude 0913207
ci: retry the fetch of a vendored test suite
claude 2f8dd4c
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 8a94bf1
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude cf92e0a
fetch: a request id that does not wrap
claude eb5d12d
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude ba9ad6e
ci: job limit of 60 minutes for the Linux asan test lane, 45 for Ubuntu
claude b38af39
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 669791b
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 17982b1
net: a closing server emits 'close' once its last socket is sent to a…
claude 6941478
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 5d8c9ab
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude cba8c81
net: what blockList.check() or a 'drop' listener throws on a TLS serv…
claude a1e2081
http2: frames queued by a promise job of the transport's write() go o…
claude a83f07a
http2: settings() and ping() callbacks are queued in the order of the…
claude 587055a
http2: a push stops counting toward maxReservedRemoteStreams when it …
claude 0f2a300
http2: session.destroy() emits 'close' on unread client streams that …
claude 2fd60b9
http2: an answer that arrives inside the transport's write() waits un…
claude 4fa3a08
http2: a server refuses its pushes above the last stream id of a GOAWAY
claude f18fee5
http2: a push that crosses settings({ enablePush: false }) is cancell…
claude c797c8e
http2: a session reads a socket that was handed over paused
claude b395d3c
http2: a transport written in JS gets no more bytes until its 'drain'
claude c6fcc96
http2: a request that is destroyed before it is submitted calls back …
claude b6b528b
http2: no DATA follows response headers that end the stream
claude 8478e7e
http2: pushStream() calls back with an error when its stream is alrea…
claude 3d0e04d
tls: a Worker can end inside an ALPNCallback
claude a9f8b3d
tls: a context selected by server name has the server's ciphers and s…
claude d8ebaab
fetch: HTTP/3 matches certificate names like the other TLS clients
claude bcf4705
tls: a TLSSocket over a stream can answer after the peer's close_notify
claude cbc463c
tls: sigalgs covers every key of a context that has several
claude ab3aa7f
http: an Agent drops an idle socket with allowHalfOpen that the serve…
claude 44feb16
tls: a client takes no servername from the options of its secureContext
claude 2017f45
test: fetch tests dial the address their server listens on
claude 7be8b4d
fetch: an idempotent request is sent again when the origin closes a r…
claude c83ee3c
fetch: a response whose reader released its lock gives its request sl…
claude 44a996f
fetch: an HTTP/2 or HTTP/3 stream gets no more window while its compr…
claude 8b55ba5
fetch: the HTTP/2 idle timeout does not run while every response wait…
claude 6da816d
node-fetch: the getters of an init whose body or tls is replaced run …
claude 35d0c96
fetch: a response through a CONNECT proxy stops being read while its …
claude 7299b9a
Bun.serve: a request with a paused body aborts when its response find…
claude d45e26e
Bun.serve: a socket stays allocated while a corked handler runs the e…
claude 19e1cbc
usockets: a read under a handler that runs the event loop gets a buff…
claude e6fa2ba
Bun.serve: HTTP/2 frames that arrive while a handler runs the event l…
claude 4d9085c
net: a socket sent to a child leaves the count of the server that acc…
claude 5a8a5ee
child_process: send() closes the socket when its message can't be ser…
claude 53db9e0
cluster: disconnect() closes an http server that listened again befor…
claude 47b6e15
cluster: an http worker binds a port after the primary has let go of it
claude 3012643
cluster: a worker drops a connection that it can't adopt instead of t…
claude 2cc6019
cluster: a worker that disconnects before the primary answered its li…
claude ef649fd
net: ref() doesn't keep the process alive for a socket with nothing t…
claude d42d22c
socket: a timeout that fires while connecting leaves the handlers in …
claude d6cc3ef
node:http: the stand-in socket of a ServerResponse emits 'finish' and…
claude edb97b2
node:http: a socket that ends finishes behind the response bytes that…
claude 07f0395
node:http: destroy() after end() closes a connection whose peer doesn…
claude 378c654
node:http: a paused socket closes when end() and the peer's FIN have …
claude d1fa467
node:https: the peer's FIN leaves the responses that are owed to the …
claude 6d35223
node:http: the stream of an Upgrade request with a body closes with n…
claude 1079f4f
node:http: a ServerResponse made in an 'upgrade' listener writes to t…
claude eb31584
node:http: a pipelined Upgrade request with a body goes to 'upgrade'
claude f6a72ab
node:http: a reader added behind socket.removeAllListeners() gets the…
claude 4bc6694
test: the record of a server socket's replaced methods has the isPaus…
claude 8254f22
node:http: a reader added while a server's socket is paused gets the …
claude 0c78ee7
http2: only a write() that returns false is backpressure; a long name…
claude 6357a3e
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude 46ddd31
http server: what a parse knows about its upgrade belongs to that parse
claude 3f99bfa
fetch: the idle deadline doesn't fire for a body that was paused afte…
claude 7276847
http2: writes of a request destroyed before it was submitted fail; un…
claude c95a1ed
socket: a named pipe that times out while connecting keeps its handle…
claude 4e92d7f
node:http: a pipelined Upgrade request with a body is answered as a r…
claude 4046b73
quic: a stream that is told to stop sending behind an unacknowledged …
claude a90a60b
http server: a read that ends right behind the target "http://" waits…
claude f67c75c
quic: a session ticket is offered only with the TLS options it was is…
claude cea486f
redis: tls.checkServerIdentity is called
claude d5030bd
node:http: a reader added to a paused server socket leaves the pause …
claude cdd7c35
node:http: the parser finishes the read it is in when the program tak…
claude c3d181e
node:http: the peer's FIN closes a connection with a 'data' listener …
claude cbb28e5
node:http: socket.end() on a paused upload keeps what the next read b…
claude c2180df
cluster: an http worker whose bind waits for the primary listens once
claude 14aea5a
node:http: a response whose socket is destroyed under its last write …
claude bf55722
node:http: a response on an emitted stream emits no 'finish' behind i…
claude ef355f8
node:http: a socket that ended closes on the responses that wait behi…
claude 00d5e2b
node:http: flushHeaders() on a response that is over doesn't throw
claude 0fe5c15
node:http: reads of a partial request head restart the socket's timeout
claude 3bdece9
node:https: a response sends nothing behind socket.end(data)
claude 44d8449
test: the record of a server's and a server socket's reads follows li…
claude 334c9ba
net: a write in flight keeps the process alive on a socket that was u…
claude ab481f2
ws: the getters of the tls and proxy options run on the object that w…
claude 3145356
node:http: a response lets go of its connection when a listener repla…
claude 1b4d04b
node:http: a response whose listener upgraded to a WebSocket closes w…
claude bb327e0
node:http: writableFinished turns true on a socket stand-in that has …
claude 3acfe8f
tls: a TLSSocket over a stream finishes after the stream took what wa…
claude 3d32b16
tls: a context selected by server name keeps the ciphers and sigalgs …
claude 80cb750
redis: tls.checkServerIdentity is read like the SQL drivers read it
claude 361c083
fetch: a paused HTTP/2 body doesn't lift the deadline of a liveness PING
claude f6bb644
node:http: the parser lets go of a socket whose reads were taken, als…
claude f81fc45
node:http: socket writes keep their order on https; end() doesn't res…
claude 89d9820
Merge remote-tracking branch 'origin/main' into claude/http-consolidated
claude df4ad7f
node:https: only the sockets that share their writes carry the mark
claude 4e8bb2c
node:http: closeIdleConnections() keeps an emitted connection whose l…
claude ff765e5
http2: the bindings of ping() and settings() say that they change the…
claude ed16a14
http2: the bindings describe the push onto that queue
claude 28f768e
node:http: read the length of the waiting responses once
claude ad84069
node:http: removeAllListeners() is a server socket's own, and listen(…
claude 57c6fe3
node:http: closeIdleConnections() asks the socket for its parser, and…
claude 915f5ef
test: the constructor of Bun.RedisClient makes its object itself
claude f8086a0
test: two tests no longer depend on how Windows sends and collects ev…
claude 6dd2b31
Merge branch 'main' into claude/http-consolidated
claude 562990e
Merge branch 'main' into claude/http-consolidated
claude ff93c73
Bun.serve: HEAD and 304 don't cancel a rewrite whose input is over
claude 50113c5
streams: that question to the rewriter is behind its handle, so Bun.s…
claude 0b74d19
test: that TLS write always leaves plaintext for the writable event
claude 2defaa8
Merge branch 'main' into claude/http-consolidated
claude 1d6c5ef
Merge branch 'main' into claude/http-consolidated
claude 069ffed
event loop: stop clearing the dead stack before immediates run
claude 3849dda
Merge branch 'main' into claude/http-consolidated
claude 901671c
Merge branch 'main' into claude/http-consolidated
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.