Skip to content

node:http: fix a process exit when a tunnel socket with a pending response is given to emit('connection') - #46421

Open
robobun wants to merge 1 commit into
mainfrom
robobun/b5ddfb28/http-emit-connection-inflight-crash
Open

node:http: fix a process exit when a tunnel socket with a pending response is given to emit('connection')#46421
robobun wants to merge 1 commit into
mainfrom
robobun/b5ddfb28/http-emit-connection-inflight-crash

node:http: fix a process exit when a tunnel socket with a pending res…

15e6478
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 22, 2026 in 7m 21s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

The root REVIEW.md applied to this review uses 26,174 of the 150,000 bytes allowed for it and any files it includes.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 2
Severity File:Line Issue
🟣 Pre-existing src/js/internal/http1_server_fallback.ts:0 A proxy whose second server has httpAllowHalfOpen set leaks the tunnel connection after the client sends FIN: the first
🟣 Pre-existing src/js/internal/http1_server_fallback.ts:0 Proxies that hand a tunnel socket to an in-process server now stay up but every request the client sends on that tunnel
View more details on Claude