Skip to content

test: start the exit timer in worker-terminate-lifetime.test.ts once the fetches have responded #45600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylan-conway merged 2 commits into from
Oct 17, 2026
Merged

test: start the exit timer in worker-terminate-lifetime.test.ts once the fetches have responded #45600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1030956
test: a worker of the streaming-request-body test exits once its fetc…
dylan-conway Oct 16, 2026
2421a68
test: say why the streaming-request-body test's workers still exit on…
dylan-conway Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/flaky-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ test/js/web/fetch/fetch.stream.test.ts # 11 of 80 builds; should drain response
test/js/web/fetch/fetch.tls.wildcard.test.ts # the peer closed the connection before the TLS handshake finished (3 builds, macOS), not root-caused
test/js/web/workers/structuredClone-classes.test.ts # 20 of 80 builds; parallel batch; (worker crashed): worker process crashed before reporting results (in the parallel bat...
test/js/web/workers/worker-late-completion.test.ts # work that comes back after its worker began tearing down > BroadcastChannel message from another thread: seen was false (build 109486, debian 13 x64-asan)
test/js/web/workers/worker-terminate-lifetime.test.ts # 11 of 80 builds; worker exit with streaming-request-body fetches whose response.body was touched: expec...
test/js/web/workers/worker-terminate-lifetime.test.ts # a worker ends while a stream is still being piped into a FileSink: Segmentation fault on a libuv-worker thread (4 builds, Windows, e.g. 126359), not root-caused
test/js/workerd/html-rewriter.test.js # 1 of 80 builds; mac
test/napi/napi-value-ffi.test.ts # 1 of 80 builds; mac; error: build failed
test/napi/napi.test.ts # 22 of 80 builds
Expand Down
15 changes: 9 additions & 6 deletions test/js/web/workers/worker-terminate-lifetime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,19 +1024,22 @@ test(
for (let i = 0; i < N; i++) {
const w = new Worker(\`
const keep = [];
const fetches = 8;
let touched = 0;
for (let j = 0; j < 8; j++) {
for (let j = 0; j < fetches; j++) {
let ctrl;
const body = new ReadableStream({ start(c) { ctrl = c; c.enqueue(new Uint8Array(1024)); } });
const p = fetch("\${server.url}", { method: "POST", body, duplex: "half" })
.then((r) => { keep.push(r.body); const rd = r.body.getReader(); rd.read(); keep.push(rd); touched++; })
.catch(() => {});
.then((r) => {
keep.push(r.body); const rd = r.body.getReader(); rd.read(); keep.push(rd);
// Every fetch has that state. The streams then run on, for a different time in each
// worker, so the exits land at arbitrary points of a transfer: no event marks those.
if (++touched === fetches) setTimeout(() => process.exit(0), 150 + \${(i * 13) % 60});
})
.catch((e) => { console.error(e); process.exit(3); });
keep.push(p, ctrl);
setInterval(() => { try { ctrl.enqueue(new Uint8Array(512)); } catch {} }, 5);
}
// Exit with that state alive; exit code 3 if no fetch ever reached it (the test would
// then not be exercising what it claims to).
setTimeout(() => process.exit(touched > 0 ? 0 : 3), 150 + \${(i * 13) % 60});
\`, { eval: true });
w.on("error", (e) => { console.error(e); process.exit(1); });
w.on("exit", (code) => {
Expand Down
Loading