Skip to content

Remove dead code from bun_format and napi.cpp #45420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 2 commits into
base: main
Choose a base branch
from
+0 −18
Open

Remove dead code from bun_format and napi.cpp #45420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cf3835
Remove dead code from bun_format and napi.cpp
robobun Oct 15, 2026
83386fc
Merge remote-tracking branch 'origin/main' into robobun/74e40cd1/dead…
robobun Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/format/js/format.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,13 +530,6 @@ impl<'a> Format<'a> for FormatExpr<'a> {
}
}

impl Spanned for FormatExpr<'_> {
#[inline]
fn span(&self) -> Span {
self.expr.span()
}
}

impl<'a> Format<'a> for Expr<'a> {
#[inline]
fn fmt(&self, f: &mut Formatter<'a>) {
Expand Down
6 changes: 0 additions & 6 deletions src/format/js/print/import_declaration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,6 @@ struct FormatSpecifier<'a, T> {
node: AstNodes<'a>,
}

impl<T: Spanned> Spanned for FormatSpecifier<'_, T> {
fn span(&self) -> Span {
self.specifier.span()
}
}

impl<'a, T: Format<'a>> Format<'a> for FormatSpecifier<'a, T> {
fn fmt(&self, f: &mut Formatter<'a>) {
if !f.is_quiet()
Expand Down
5 changes: 0 additions & 5 deletions src/jsc/bindings/napi.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3429,11 +3429,6 @@ extern "C" bool NapiEnv__hasPendingException(napi_env env)
return scope.exception() != nullptr;
}

extern "C" uint32_t Bun__napi_get_version(napi_env env)
{
return env->napiModule().nm_version;
}

// napi_ok, or the status NAPI_RETURN_IF_CANNOT_CALL_INTO_JS returns (not yet set as the last error).
extern "C" napi_status NapiEnv__checkCanCallIntoJS(napi_env env)
{
Expand Down
Loading