Repository navigation
sql: reject a query cancelled before it runs, finish close({ timeout }) when the work drains, send no COMMIT after tx.close() #44799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f21a388
sql: reject a query that is cancelled before it runs
robobun 8d03dd6
sql: close the reserved connection when close({ timeout }) drains bef…
robobun 884c8e9
sql: roll back when transaction.close({ timeout }) drains before the …
robobun aa908f9
test(sql): tx.close({ timeout }) rolls back with a pending, cancelled…
robobun b854f04
sql: one rollback for a closing transaction, shared by close() and th…
robobun e82afc6
test(sql): transaction.close() orders on the shared mocks, main's cas…
robobun 3f666a6
sql: close() clears the shared rollback when its own ROLLBACK fails
robobun cafb145
test(sql): pin the execute() path of a query cancelled before it runs
robobun 7c3bffd
sql: read the transaction state once in the runner's catch path, one-…
robobun 445615f
sql: the runner sends its own ROLLBACK when the one of close() failed
robobun 09211d7
types: cancel() cancels a query, also one that has not started
robobun 0fef54d
sql: the runner reads state.rollback once, so close() and the runner …
robobun 174ae0a
sql: close({ timeout }) settles with the rollback that the runner sen…
robobun 413baa5
Merge remote-tracking branch 'origin/main' into robobun/7f41ed85/sql-…
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.