Repository navigation

Resolve a module specifier once: fix a segfault in require() of an ES module, and require() with a plugin's namespace - #44473

Merged

dylan-conway merged 19 commits into

mainfrom

claude/module-key-resolved-once

Oct 3, 2026

Commits on Oct 2, 2026

The module loader's resolve hook returns a key it is asked about without a referrer
dylan-conway
committed
afeb9e0
Ask a plugin's onResolve when the code runs, not also while it is transpiled
dylan-conway
committed
520fabd
Bun__onDidAppendPlugin takes only the VM
dylan-conway
committed
533cb17
What Bun loads itself is resolved once before the loader gets it
dylan-conway
committed
758b1f6
The resolve hook takes the loader's word, useImportMap, for what is a key already
dylan-conway
committed
7915a63
Merge the base branch, and import() hands the loader the specifier and its referrer
dylan-conway
committed
4931b0f
What onResolve answers without a namespace goes on to the resolver, from the same importer
dylan-conway
committed
6c23874
Merge the base branch, bump the transpiler cache version, and drop two continues that skip nothing
dylan-conway
committed
1e94b23
What Bun loads itself is resolved and then loaded by its key, in one place
dylan-conway
committed
dbc8bb1
Merge the branch that asks onResolve only when the code runs
dylan-conway
committed
4d04cdb
What onResolve answers is resolved by all but onResolve, and a path in a namespace that has an onLoad is a key
dylan-conway
committed
b430279
What onResolve answers goes back through the resolver with onResolve off, and Bun.ModuleGraph's import() loads by the key it resolved
dylan-conway
committed
7a9adc5
Test that a symlink onResolve answers is the module of its real path
dylan-conway
committed
9ad2cfe
Remove what the deleted plugin block left dead in the linker, the unused target of the plugin bindings, and the copy of whether plugins are registered
dylan-conway
committed
455e3f2
Give JSC::loadAndEvaluateModule the key Bun's resolver answers, and remove a path helper nothing uses
dylan-conway
committed
d9ee594
Make the tests of a symlink and of a path that is too long hold on Windows, and test a file written after its directory was read
dylan-conway
committed
ad4099b

Navigation Menu

Repository navigation

Resolve a module specifier once: fix a segfault in require() of an ES module, and require() with a plugin's namespace - #44473

Resolve a module specifier once: fix a segfault in require() of an ES module, and require() with a plugin's namespace#44473
dylan-conway merged 19 commits into
mainfrom
claude/module-key-resolved-once

Commits on Oct 2, 2026

The module loader's resolve hook returns a key it is asked about without a referrer

Ask a plugin's onResolve when the code runs, not also while it is transpiled

Bun__onDidAppendPlugin takes only the VM

What Bun loads itself is resolved once before the loader gets it

The resolve hook takes the loader's word, useImportMap, for what is a key already

Merge the base branch, and import() hands the loader the specifier and its referrer

What onResolve answers without a namespace goes on to the resolver, from the same importer

Merge the base branch, bump the transpiler cache version, and drop two continues that skip nothing

What Bun loads itself is resolved and then loaded by its key, in one place

Merge the branch that asks onResolve only when the code runs

What onResolve answers is resolved by all but onResolve, and a path in a namespace that has an onLoad is a key

What onResolve answers goes back through the resolver with onResolve off, and Bun.ModuleGraph's import() loads by the key it resolved

Test that a symlink onResolve answers is the module of its real path

Remove what the deleted plugin block left dead in the linker, the unused target of the plugin bindings, and the copy of whether plugins are registered

Give JSC::loadAndEvaluateModule the key Bun's resolver answers, and remove a path helper nothing uses

Make the tests of a symlink and of a path that is too long hold on Windows, and test a file written after its directory was read

Commits on Oct 3, 2026

Ask whether an onLoad would be called for a key the way loading it does

Call JSModuleLoader::resolve and JSC::loadAndEvaluateModule where a name is loaded, and only the latter where it is a key

Close the gap the removed import record flag left