Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small follow-up to #40503 for three
keepNamesedge cases:__name()read so minification cannot inline away a block-scoped function binding.??=,||=, and&&=assignments.namemethods, accessors, and fields intact.The patch adds focused runtime tests and keeps the existing tree-shaking test unchanged.
How did you verify your code works?
BUN_EXE="$PWD/build/debug/bun-debug" ./build/debug/bun-debug test test/bundler/bundler_minify.test.ts— 51 pass, 0 fail.git diff --check b406b4bd..HEAD— clean.Merge Danger
Door: Two-way. Blast radius:
keepNamesoutput and the__nameruntime helper. This targets the feature branch, so #40503 can absorb or adjust it before landing onmain.