Skip to content

react-compiler: compile a lazy ref init next to a closure, and ref={row.ref} in a callback #43636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 2 commits into
base: main
Choose a base branch
from
Open

react-compiler: compile a lazy ref init next to a closure, and ref={row.ref} in a callback #43636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc1285
react-compiler: stop ValidateNoRefAccessInRender when a nested fixpoi…
robobun Sep 20, 2026
a702d06
react-compiler: compile a lazy ref init next to a closure, and `ref={…
robobun Sep 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 9 additions & 23 deletions src/react_compiler/validation/validate_no_ref_access_in_render.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,13 +501,7 @@ fn guard_check(errors: &mut Vec<CompilerDiagnostic>, operand: &Place, env: &Env)

pub(crate) fn validate_no_ref_access_in_render(func: &HirFunction, env: &mut Environment) {
let mut ref_env = Env::new();
collect_temporaries_sidemap(
func,
&mut ref_env,
&env.identifiers,
&env.types,
&env.functions,
);
collect_temporaries_sidemap(func, &mut ref_env, &env.identifiers, &env.types);
let mut errors: Vec<CompilerDiagnostic> = Vec::new();
validate_no_ref_access_in_render_impl(
func,
Expand All @@ -528,17 +522,11 @@ fn collect_temporaries_sidemap(
env: &mut Env,
identifiers: &[Identifier],
types: &[Type],
functions: &[HirFunction],
) {
for (_, block) in &func.body.blocks {
for &instr_id in &block.instructions {
let instr = &func.instructions[instr_id.0 as usize];
match &instr.value {
InstructionValue::ObjectMethod { lowered_func, .. }
| InstructionValue::FunctionExpression { lowered_func, .. } => {
let inner = &functions[lowered_func.func.0 as usize];
collect_temporaries_sidemap(inner, env, identifiers, types, functions);
}
InstructionValue::LoadLocal { place, .. } => {
let temp = env
.temporaries
Expand Down Expand Up @@ -596,16 +584,6 @@ fn validate_no_ref_access_in_render_impl(
ref_type_of_type(place.identifier, identifiers, types),
);
}
// Seed captured context places so refs captured from an enclosing scope are
// recognized as Ref/RefValue inside the lambda body. Callbacks passed to
// useState/useReducer (and IIFEs) execute during render, so a captured ref
// read must be detected here for `read_ref_effect` to propagate.
for place in &func.context {
ref_env.set(
place.identifier,
ref_type_of_type(place.identifier, identifiers, types),
);
}

// Collect identifiers that are interpolated as JSX children
let mut interpolated_as_jsx: HashSet<IdentifierId> = HashSet::default();
Expand Down Expand Up @@ -778,6 +756,14 @@ fn validate_no_ref_access_in_render_impl(
ref_env,
&mut inner_errors,
);
// Not in upstream: the TypeScript original throws this invariant.
if inner_errors
.iter()
.any(|error| error.category == ErrorCategory::Invariant)
{
errors.append(&mut inner_errors);
return RefAccessType::None;
}
let (return_type, read_ref_effect) = if inner_errors.is_empty() {
(result, false)
} else {
Expand Down
Loading
Loading