Skip to content

node:http2: end a paused server stream that holds no data when it closes - #43631

Open
robobun wants to merge 1 commit into
mainfrom
robobun/c5edf1ad/http2-paused-server-stream-end
Open

node:http2: end a paused server stream that holds no data when it closes#43631
robobun wants to merge 1 commit into
mainfrom
robobun/c5edf1ad/http2-paused-server-stream-end

node:http2: end a paused server stream that holds no data when it closes

a8a4926
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Sep 20, 2026 in 14m 34s

Code review found 2 potential issues

Found 4 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 1
Severity File:Line Issue
🟡 Nit src/js/node/http2.ts:4066 Servers that pause a request and then reject it with close(code) now get a spurious 'end' event before 'close'; the base
🟣 Pre-existing src/js/node/http2.ts:0 Client callers whose stream closes inside req.end(chunk) still lose 'finish' and get ERR_STREAM_DESTROYED in the end() c
View more details on Claude