Skip to content

test: refresh VM thread-door inventory - #43228

Merged
Jarred-Sumner merged 1 commit into
oven-sh:mainfrom
steipete:claude/vm-thread-door-inventory
Sep 18, 2026
Merged

Jarred-Sumner merged 1 commit into
oven-sh:mainfrom
steipete:claude/vm-thread-door-inventory

Conversation

@steipete

Copy link
Copy Markdown
Collaborator

What changed

Refresh the VM thread-door source-lint inventory after #43174 removed the final direct thread spawn from GarbageCollectionController.rs.

The stale entry currently makes the source-lints workflow fail on unchanged main and on unrelated pull requests, including #43222.

Validation

  • bun test test/internal/source-lints/vm-thread-door.test.ts
  • bun test test/internal/source-lints/ (173 pass)

AI-assisted: this change was prepared and validated with Codex.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: df5d1d3e-3810-4d9b-ba6d-8e387e18699f

📥 Commits

Reviewing files that changed from the base of the PR and between b2c1097 and d4f75dd.

📒 Files selected for processing (1)
  • test/internal/source-lints/vm-thread-door.inventory.json
💤 Files with no reviewable changes (1)
  • test/internal/source-lints/vm-thread-door.inventory.json

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


Walkthrough

Changes

Source-lint inventory

Layer / File(s) Summary
Update thread-spawn inventory
test/internal/source-lints/vm-thread-door.inventory.json
Removes the GarbageCollectionController.rs entry with one recorded "thread spawn" finding. Other inventory entries remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to d4f75

The change removes an obsolete source-lint inventory entry, with no remaining concrete merge risk identified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the change: refreshing the VM thread-door inventory test fixture.
Description check ✅ Passed The description explains what changed, why the stale inventory entry caused failures, and how the change was verified. It uses different headings from the template but includes the required informatio…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@Jarred-Sumner
Jarred-Sumner merged commit 898f9fe into oven-sh:main Sep 18, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants