Repository navigation
EventTarget: skip a listener object that has no realm #42517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { expect, test } from "bun:test"; | ||
| import { bunEnv, bunExe } from "harness"; | ||
|
|
||
| // A WebAssembly GC object is the one kind of object that plain JS can hold whose structure | ||
| // has no realm, so JSObject::globalObject() is null for it. addEventListener() accepts any | ||
| // object as a listener, which used to make the dispatch read that null realm. | ||
| // | ||
| // (module | ||
| // (type $s (struct (field (mut i32)))) | ||
| // (func (export "mk") (result (ref null $s)) struct.new_default $s)) | ||
| const makeWasmGCObject = ` | ||
| const bytes = new Uint8Array([0,0x61,0x73,0x6d,1,0,0,0, 1,10,2, 0x5f,1,0x7f,1, 0x60,0,1,0x63,0, 3,2,1,1, 7,6,1,2,0x6d,0x6b,0,0, 10,7,1,5,0,0xfb,1,0,0x0b]); | ||
| const listener = new WebAssembly.Instance(new WebAssembly.Module(bytes)).exports.mk(); | ||
| `; | ||
|
|
||
| test.concurrent("dispatchEvent() does not crash on a WebAssembly GC object listener", async () => { | ||
| await using proc = Bun.spawn({ | ||
| cmd: [ | ||
| bunExe(), | ||
| "-e", | ||
| `${makeWasmGCObject} | ||
| const target = new EventTarget(); | ||
| target.addEventListener("a", listener); | ||
| target.dispatchEvent(new Event("a")); | ||
| console.log("survived");`, | ||
| ], | ||
| env: bunEnv, | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
|
|
||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
|
|
||
| expect(stdout).toBe("survived\n"); | ||
| expect(stderr).toContain("'handleEvent' property of event listener should be callable"); | ||
| expect(exitCode).toBe(1); | ||
| }); | ||
|
|
||
| test.concurrent("AbortSignal abort does not crash on a WebAssembly GC object listener", async () => { | ||
| await using proc = Bun.spawn({ | ||
| cmd: [ | ||
| bunExe(), | ||
| "-e", | ||
| `${makeWasmGCObject} | ||
| const controller = new AbortController(); | ||
| controller.signal.addEventListener("abort", listener); | ||
| controller.abort(); | ||
| console.log("survived");`, | ||
| ], | ||
| env: bunEnv, | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
|
|
||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
|
|
||
| expect(stdout).toBe("survived\n"); | ||
| expect(stderr).toContain("'handleEvent' property of event listener should be callable"); | ||
| expect(exitCode).toBe(1); | ||
| }); | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.