Skip to content

Add inline sourcemaps when --inspect is enabled - #4213

Merged
Jarred-Sumner merged 3 commits into
mainfrom
jarred/inline
Aug 19, 2023
Merged

Jarred-Sumner merged 3 commits into
mainfrom
jarred/inline

Conversation

@Jarred-Sumner

Copy link
Copy Markdown
Collaborator

What does this PR do?

This adds inline sourcemaps when --inspect is enabled. Inline sourcemaps are really slow. This makes every source file about 2x - 3x larger in-memory. But you need sourcemaps to debug in Bun properly.

How did you verify your code works?

Manually tested in web inspector

@Jarred-Sumner
Jarred-Sumner merged commit 86ad015 into main Aug 19, 2023
@Jarred-Sumner
Jarred-Sumner deleted the jarred/inline branch August 19, 2023 07:20
@github-actions

Copy link
Copy Markdown
Contributor

❌ @Jarred-Sumner 1 files with test failures on linux-x64-baseline:

  • test/cli/install/bun-install.test.ts

View test output

#1446f58cffac0fa6bc47d16a6bcfbdc1f4a55724

@github-actions

Copy link
Copy Markdown
Contributor

❌ @Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/dns/node-dns.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watch.test.ts
  • test/js/web/worker.test.ts

View test output

#1446f58cffac0fa6bc47d16a6bcfbdc1f4a55724

@github-actions

Copy link
Copy Markdown
Contributor

❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn-streaming-stdin.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#1446f58cffac0fa6bc47d16a6bcfbdc1f4a55724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants