Add util.inspect.custom support to util.inspect/Bun.inspect/console.log - #4194
Merged
Merged
Conversation
Jarred-Sumner
marked this pull request as draft
August 17, 2023 21:28
paperclover
force-pushed
the
util-inspect-custom
branch
from
August 17, 2023 23:58
d0792b0 to
1e68a86
Compare
paperclover
marked this pull request as ready for review
August 18, 2023 00:18
paperclover
force-pushed
the
util-inspect-custom
branch
from
August 18, 2023 00:20
ba9f239 to
eeff3e3
Compare
Contributor
|
❌ @paperdave 1 files with test failures on linux-x64:
|
Contributor
|
❌ @paperdave 1 files with test failures on linux-x64-baseline:
|
Contributor
|
❌ @paperdave 5 files with test failures on bun-darwin-x64-baseline:
|
Jarred-Sumner
marked this pull request as draft
August 18, 2023 02:03
Contributor
|
❌ @paperdave 5 files with test failures on bun-darwin-aarch64:
|
paperclover
force-pushed
the
util-inspect-custom
branch
from
August 18, 2023 02:32
3fb3247 to
34eb7cc
Compare
paperclover
marked this pull request as ready for review
August 18, 2023 02:32
Collaborator
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This merges
util.inspectandBun.inspect, as well as gives the console formatter support for callingutil.inspect.customfunctions.Breaking change:
Bun.inspectinstead of taking variadic arguments, it will function exactly likeutil.inspect.How did you verify your code works?
make jsand committed the transpiled changesbun fmt)zig fmton the changed files