Skip to content

Make line coverage follow the innermost JSC block #41528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robobun wants to merge 10 commits into from
Closed

Make line coverage follow the innermost JSC block #41528

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb69be1
coverage: let the innermost JSC range decide whether a line executed
robobun Sep 6, 2026
bf4780e
Use the WebKit preview build for oven-sh/WebKit#570
robobun Sep 6, 2026
4460d8e
test: line coverage follows the innermost JSC range
robobun Sep 6, 2026
fd166c7
test: update coverage snapshots for per-block hit counts
robobun Sep 6, 2026
dea45fc
rustfmt
robobun Sep 6, 2026
ea6dca5
test: update the bytecode portability snapshot for the WebKit preview
robobun Sep 6, 2026
4030572
coverage: shorter comments
robobun Sep 6, 2026
883ba6d
test: keep the fixture imports unchanged
robobun Sep 6, 2026
bca35c5
test: drain stdout and drop the stderr substring check
robobun Sep 6, 2026
f9348c6
Pin the updated oven-sh/WebKit#570 preview and cover a short-circuite…
robobun Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion scripts/build/deps/webkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* for local mode. Override via `--webkit-version=<hash>` to test a branch.
* From https://github.com/oven-sh/WebKit releases.
*/
export const WEBKIT_VERSION = "2e2aa2290fac856d6f451ceacb58f7f5b44dd057";
export const WEBKIT_VERSION = "autobuild-preview-pr-570-c685afa2";

@claude claude Bot Sep 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 WEBKIT_VERSION is pinned to autobuild-preview-pr-570-c685afa2, an ephemeral preview-PR artifact; merging this makes every fresh checkout's build depend on a release that will be deleted once oven-sh/WebKit#570 lands or is closed. Fix: land oven-sh/WebKit#570 first and pin WEBKIT_VERSION to the resulting merged commit SHA before this PR merges (per Dependencies & vendoring: never merge a pin to an ephemeral artifact).

Extended reasoning...

The prebuilt WebKit dep resolves its download URL from WEBKIT_VERSION. autobuild-preview-* releases on oven-sh/WebKit are transient CI artifacts for unmerged PRs and are garbage-collected; once PR 570 merges or the preview is pruned, bun bd on a clean cache fails at the WebKit fetch step for every developer and CI lane. The base branch pins a stable 40-char merged SHA (2e2aa2290fac856d6f451ceacb58f7f5b44dd057). The PR description acknowledges this is a preview build; the conventions block explicitly calls this out as must-swap-before-merge.

Verification: normal — scripts/build/deps/webkit.ts:6 changes WEBKIT_VERSION from the stable 40-char merged SHA "2e2aa2290fac856d6f451ceacb58f7f5b44dd057" to "autobuild-preview-pr-570-c685afa2". The codebase itself documents that these tags are ephemeral — scripts/build/download.ts:314-331: "The autobuild-preview-pr-* WebKit tags are the sharp edge: GitHub deletes the preview release when the PR…


/**
* WebKit (JavaScriptCore) — the JS engine.
Expand Down
1 change: 0 additions & 1 deletion src/sourcemap_jsc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ bun_core.workspace = true
bun_collections.workspace = true
bun_io.workspace = true
bun_jsc.workspace = true
bun_ast.workspace = true
bun_options_types.workspace = true
bun_paths.workspace = true
# bun_runtime — only used in BakeSourceProvider::get_external_data, which is
Expand Down
Loading
Loading