Skip to content

usockets: stagger connect attempts to the addresses of a name (RFC 8305) - #41501

Open
robobun wants to merge 6 commits into
mainfrom
robobun/6870328b/connect-attempt-delay
Open

robobun wants to merge 6 commits into
mainfrom
robobun/6870328b/connect-attempt-delay

test: count connections per dial, with a bound that a stalled machine…

445215e
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Oct 21, 2026 in 10m 18s

Code review found 1 new issue (2 earlier findings still open)

Resolved 2 earlier findings in this review; 2 still open. Found 1 candidates, confirmed 3: 1 posted in this review, 2 from earlier reviews still open. See review comments for details.

The root REVIEW.md applied to this review uses 26,174 of the 150,000 bytes allowed for it and any files it includes.

Details

Severity Count
🔴 Important 0
🟡 Nit 3
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/js/bun/dns/dns-interleave.test.ts:255 nit: the timing assertion in the new stagger test cannot fail on its own, so maintainers get no signal from it. With 'si