Repository navigation
Pin a real simdutf kernel when CPUID dispatch picks the unsupported stub #41374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
4
commits into
main
Choose a base branch
from
robobun/90d3294d/simdutf-unsupported-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
49f5e7a
Pin a real simdutf kernel when CPUID dispatch picks the unsupported stub
robobun 00f7171
test: rely on the runner timeout instead of a spawn timeout
robobun 8346d31
Shorten the simdutf init comments, assert the child exited on its own
robobun fefc6d2
ci: retrigger
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { expect, test } from "bun:test"; | ||
| import { bunEnv, bunExe, tempDir } from "harness"; | ||
|
|
||
| // simdutf picks its SIMD kernel by CPUID at first use. When no compiled-in | ||
| // kernel matches (QEMU's default CPU model hides SSE4.2), it installs a stub | ||
| // whose every call returns 0 or false. SIMDUTF_FORCE_IMPLEMENTATION with an | ||
| // unknown name installs the same stub on any machine. Bun used to spin forever | ||
| // in a Latin-1 to UTF-8 loop on the first ASCII string longer than 32 bytes, | ||
| // which is the entry point path, before it opened the entry file. | ||
| test("bun starts when simdutf finds no supported kernel", async () => { | ||
|
coderabbitai[bot] marked this conversation as resolved.
Resolved
|
||
| using dir = tempDir("simdutf-no-supported-kernel", { | ||
| "entry-file-with-a-name-longer-than-thirty-two-bytes.mjs": `console.log("ok");`, | ||
| }); | ||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), `${dir}/entry-file-with-a-name-longer-than-thirty-two-bytes.mjs`], | ||
| env: { ...bunEnv, SIMDUTF_FORCE_IMPLEMENTATION: "bogus" }, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
| expect(stdout).toBe("ok\n"); | ||
| expect(stderr).toBe(""); | ||
| expect(proc.signalCode).toBeNull(); | ||
| expect(exitCode).toBe(0); | ||
|
robobun marked this conversation as resolved.
Resolved
|
||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.