Skip to content

docs: note unsupported dependencies lifecycle script - #41350

Open
deepshekhardas wants to merge 1 commit into
oven-sh:mainfrom
deepshekhardas:docs/30247-lifecycle-dependencies-script
Open

deepshekhardas wants to merge 1 commit into
oven-sh:mainfrom
deepshekhardas:docs/30247-lifecycle-dependencies-script

Conversation

@deepshekhardas

Copy link
Copy Markdown

Fixes #30247.

Fixes oven-sh#30247. The lifecycle docs listed common scripts with a pointer to npm's full list, but Bun does not run npm's \dependencies\ script. Add a note saying so.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 9a8b49a1-f24f-42d1-80f7-477fc5bd4853

📥 Commits

Reviewing files that changed from the base of the PR and between 4661e49 and 8e53a1e.

📒 Files selected for processing (1)
  • docs/pm/lifecycle.mdx

Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review.


Walkthrough

The lifecycle scripts documentation now includes a note that Bun does not implement npm's dependencies script, which runs after node_modules changes.

Changes

Lifecycle script documentation

Layer / File(s) Summary
Document unsupported lifecycle script
docs/pm/lifecycle.mdx
Adds a <Note> stating that npm's dependencies script is not implemented in Bun and will not run.

Suggested reviewers: robobun

Merge Risk: ⚪ Minimal · up to 8e53a

The lifecycle documentation now clearly states that Bun does not run npm’s unsupported dependencies script. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only references issue #30247 and does not include the required summary or verification sections. Add completed sections for what the PR does and how the documentation change was verified.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change: noting that the npm dependencies lifecycle script is unsupported.
Linked Issues check ✅ Passed The PR documents that Bun does not implement or execute npm's dependencies lifecycle script, which satisfies the primary requirement in issue #30247.
Out of Scope Changes check ✅ Passed The change is limited to the lifecycle documentation and is directly related to issue #30247. No unrelated changes are identified.
  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation does not mention that the "dependencies" package.json script is not implemented

1 participant