docs: note unsupported dependencies lifecycle script - #41350
Open
deepshekhardas wants to merge 1 commit into
Open
deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
Fixes oven-sh#30247. The lifecycle docs listed common scripts with a pointer to npm's full list, but Bun does not run npm's \dependencies\ script. Add a note saying so.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. WalkthroughThe lifecycle scripts documentation now includes a note that Bun does not implement npm's ChangesLifecycle script documentation
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The lifecycle documentation now clearly states that Bun does not run npm’s unsupported dependencies script. No current merge-readiness risk remains. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30247.