Fixes #4089 - #4105
Merged
Merged
Fixes #4089#4105
Conversation
Contributor
|
❌ @Jarred-Sumner 6 files with test failures on bun-darwin-aarch64:
|
Contributor
|
❌ @Jarred-Sumner 2 files with test failures on linux-x64-baseline:
|
Contributor
|
❌ @Jarred-Sumner 1 files with test failures on linux-x64:
|
Contributor
|
❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64-baseline:
|
dylan-conway
approved these changes
Aug 11, 2023
dylan-conway
left a comment
dylan-conway
left a comment
Member
There was a problem hiding this comment.
LGTM after isStrictEqual change
1 of 2 tasks
robobun
added a commit
that referenced
this pull request
Oct 1, 2026
…s and the JSDoc The `deepEquals URLs` test reads every row of its table, and states that a plain copy of a URL's properties does not equal the URL. That pair was equal in `toEqual` and not equal in `toStrictEqual` (#4105). The new tests no longer pin the `Symbol.toStringTag` of `fs.Stats`, `fs.Dirent`, `req.params` and the `toJSON()` results. The elysia skips in `test/vendor.json` say how many tests of each file still pass. The `toEqual` JSDoc states the rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4089
How did you verify your code works?
Automated tests