Repository navigation
sql: report affectedRows on PostgreSQL and SQLite query results #40434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
97b15ab
sql: report affectedRows on PostgreSQL and SQLite query results
robobun 891a9ff
sql(sqlite): report 0 affectedRows for EXPLAIN of a write
robobun a03af16
sql: shorten result metadata comments
robobun ee5f4b2
sql(sqlite): skip leading comments when classifying the statement
robobun f0b96a5
sql(sqlite): report null affectedRows for a CTE write without RETURNING
robobun 0dd58e5
sql(sqlite): classify the write verb independently of the first token
robobun 4a73dc5
sql: shorten a parser comment
robobun 1f41110
[autofix.ci] apply automated fixes
autofix-ci[bot] 287545f
sql(sqlite): only accept a write verb at parenthesis depth zero
robobun 5c01aac
sql(sqlite): pin CTE UPDATE tests with WHERE, soften affectedRows docs
robobun da7328a
sql(sqlite): handle quoted identifiers in comment stripping, pin mult…
robobun 3b5543a
sql: document that multi-result queries carry metadata on the inner a…
robobun 8573e09
Restore the adapter changes lost in the previous commit
robobun 9d8d428
sql: correct the SQLite count docs
robobun f6c2ed9
ci: retrigger
robobun 611b33b
sql(sqlite): pin the upsert command value
robobun 3977ddc
sql(sqlite): require INTO after REPLACE, reset scan state at statemen…
robobun 57e6ecd
[autofix.ci] apply automated fixes
autofix-ci[bot] 77e4213
sql: reset command at statement boundaries, accept quoted identifiers…
robobun f0797e6
sql(sqlite): track backtick and bracket identifier quotes in the toke…
robobun eb8455f
sql(sqlite): reset canReturnRows at statement boundaries
robobun d30940b
sql(sqlite): treat a quote opener as a token boundary
robobun 3734e2b
sql: shorten a scanner comment
robobun 069157a
sql(sqlite): classify tokens flushed at quote boundaries
robobun 95a439f
sql(sqlite): classify tokens at the closing paren, accept a single-qu…
robobun 4cec6e2
sql(sqlite): treat the opening paren as a token boundary
robobun ed3c09a
sql: shorten a scanner comment
robobun 11b06ad
sql: drop an over-general claim from the multi-statement docs
robobun f973e33
sql(sqlite): gate canReturnRows on parenthesis depth
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.