Make bun_core::String own its WTF ref - #40238

Merged

Jarred-Sumner merged 29 commits into

mainfrom

claude/bun-core-string-leaks-3ff1dd

Aug 24, 2026

Commits on Aug 23, 2026

Make bun_core::String own its WTF ref (Drop = deref, Clone = ref)
dylan-conway
committed
3fac049
Address clippy: borrow instead of by-value String params, drop identity .into()
dylan-conway
committed
f56f83c
Add regression test for the jsonb bind leak (#40102); propagate into_dto errors
dylan-conway
committed
07e13f7
Merge remote-tracking branch 'origin/main' into claude/bun-core-string-leaks-3ff1dd
dylan-conway
committed
d6df770
Trim refcount traffic: into_js for last-use strings, borrow TOML key path
dylan-conway
committed
8d4d029
Simplify around the owning String: drop StringCell, return values not out-params
dylan-conway
committed
1abee86
Fix putIndex on non-array objects (http2 custom settings), address review nits
dylan-conway
committed
b7691c1
FFI: a by-value String in an extern signature means ownership crosses
dylan-conway
committed
9686e63
Second simplification pass: return Strings instead of writing out-params
dylan-conway
committed
409a4cd
ZigException::Holder: drop only the populated frame/source-line prefixes
dylan-conway
committed
6b64206
shell lexer: drop stale borrowck comment on string_refs
dylan-conway
committed
e22735d
bun_core::String: spell the inner POD as bun_alloc::String, drop the RawString alias
dylan-conway
committed
045baf2
node_process: fix getRedirectWarnings doc comment
dylan-conway
committed
e34fd40
Remove JSValue::get_zig_string/to_zig_string; JSString::view is lifetime-tied
dylan-conway
committed
83737ac
Third pass: one-FFI JSString views, owned class/name getters, drop ZigErrorType
dylan-conway
committed
9b40b6b
Drop LoaderHooks table, tie property-iterator names to the iterator, one URL wrapper
dylan-conway
committed
6b8c76f
Merge remote-tracking branch 'origin/main' into claude/bun-core-string-leaks-3ff1dd
dylan-conway
committed
c09b5ec
Review follow-ups: static symbol_for keys, borrowed symbol description, typed TranspileArgs.extra; commit Cargo.lock
dylan-conway
committed
eb6b654
ZigException::Holder::deinit takes &mut self so the boxed holder is not moved onto the stack
dylan-conway
committed
3aad87c
DevServer: hand the server HMR runtime to JSC as a static external string
dylan-conway
committed
fd9863e
JSStringView: a borrowed JSString view that pins the cell while alive
dylan-conway
committed
76a30ab
postgres-json-bind-leak test: widen RSS bound for macOS allocator slack (leak is ~160 MiB)
dylan-conway
committed
79251c6
Rename JSC__JSValue__toStringAndView to JSC__JSValue__toJSStringView to match the Rust API
dylan-conway
committed
f900aa5
Add regression tests for eight of the string leaks
dylan-conway
committed
ad949cf

Navigation Menu

Make bun_core::String own its WTF ref - #40238

Make bun_core::String own its WTF ref#40238
Jarred-Sumner merged 29 commits into
mainfrom
claude/bun-core-string-leaks-3ff1dd

Commits on Aug 23, 2026

Make bun_core::String own its WTF ref (Drop = deref, Clone = ref)

Address clippy: borrow instead of by-value String params, drop identity .into()

Add regression test for the jsonb bind leak (#40102); propagate into_dto errors

Merge remote-tracking branch 'origin/main' into claude/bun-core-string-leaks-3ff1dd

Trim refcount traffic: into_js for last-use strings, borrow TOML key path

Simplify around the owning String: drop StringCell, return values not out-params

Fix putIndex on non-array objects (http2 custom settings), address review nits

FFI: a by-value String in an extern signature means ownership crosses

Second simplification pass: return Strings instead of writing out-params

ZigException::Holder: drop only the populated frame/source-line prefixes

shell lexer: drop stale borrowck comment on string_refs

bun_core::String: spell the inner POD as bun_alloc::String, drop the RawString alias

node_process: fix getRedirectWarnings doc comment

Remove JSValue::get_zig_string/to_zig_string; JSString::view is lifetime-tied

Third pass: one-FFI JSString views, owned class/name getters, drop ZigErrorType

Drop LoaderHooks table, tie property-iterator names to the iterator, one URL wrapper

Merge remote-tracking branch 'origin/main' into claude/bun-core-string-leaks-3ff1dd

Review follow-ups: static symbol_for keys, borrowed symbol description, typed TranspileArgs.extra; commit Cargo.lock

ZigException::Holder::deinit takes &mut self so the boxed holder is not moved onto the stack

DevServer: hand the server HMR runtime to JSC as a static external string

JSStringView: a borrowed JSString view that pins the cell while alive

postgres-json-bind-leak test: widen RSS bound for macOS allocator slack (leak is ~160 MiB)

Rename JSCJSValuetoStringAndView to JSCJSValuetoJSStringView to match the Rust API

Add regression tests for eight of the string leaks

Commits on Aug 24, 2026

Add regression test for leaked RESP map keys (150 MiB on 1.4.0 via a mock server)

ModuleLoader.cpp: Bun__fetchBuiltinModule returning true implies success in fetchESMSourceCode too; drop stale URL holder comments

doc: point to_utf8_borrowed / WtfBorrowed docs at String::into_slice

Merge remote-tracking branch 'origin/main' into claude/bun-core-string-leaks-3ff1dd

Review round: JSString::view without flattening, FFI consume/read consistency, URL RAII, dead params