Repository navigation
webstreams: propagate exceptions through helpers, convert only at boundaries #39913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8ee933f
webstreams: propagate exceptions through helpers; convert only at bou…
dylan-conway ac3e2b1
webstreams: no helper handles a pending exception; boundaries are exp…
dylan-conway 890bdda
Direct controller close(): finish the mechanical close before running…
dylan-conway 37b8c88
Boundaries get an optional last-resort settle; read() converts to a r…
dylan-conway a906b32
errorCodeIs: follow stored prototypes (Bun's coded errors keep `code`…
dylan-conway 2b21c63
intoArraySettle: only the first settle counts (release throwing after…
dylan-conway 40314e8
Direct controller: pull-fulfilled reaction and close() are enterStrea…
dylan-conway a92d174
test: wait for pull() via a resolver instead of sleep(0)
dylan-conway 6092cd8
Direct controller reactions report an undeliverable error; rsis ignor…
dylan-conway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
220 changes: 87 additions & 133 deletions
220
src/jsc/bindings/webcore/streams/BunAsyncIterableSource.cpp
Large diffs are not rendered by default.
Oops, something went wrong.
309 changes: 119 additions & 190 deletions
309
src/jsc/bindings/webcore/streams/BunStreamConsumers.cpp
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
202 changes: 101 additions & 101 deletions
202
src/jsc/bindings/webcore/streams/JSCompressionStreamShared.cpp
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.