Repository navigation
Bun.file: a failed stat leaves the size unknown #39763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
8a36cb5
Bun.file: do not cache a failed stat, stat on every exists()
robobun 2920f8f
test: cover lastModified reset and a non-ENOENT stat failure
robobun b67b250
Shorten comments, assert the exact error code per platform
robobun e2280ba
test: check the copied content, not the byte count Windows does not r…
robobun e071cc2
Say failed stat, not missing file, in the two fallback comments
robobun ea18ccd
ci: retrigger
robobun d66c588
test: exists() on an existing file does not cap later reads, slice ke…
robobun 5ca4525
test: cover the fd arm, the size reset after a failed stat, a slice o…
robobun 5d6fc6a
test: close the fd on every exit path of the fd exists() test
robobun 8c039e1
Merge remote-tracking branch 'origin/main' into farm/e27dc7cb/bunfile…
robobun 09fb817
Merge origin/main into farm/e27dc7cb/bunfile-failed-stat-not-cached
robobun b85ecd7
Merge origin/main into farm/e27dc7cb/bunfile-failed-stat-not-cached
robobun ab0896c
Bun.file: a failed stat leaves the size unknown
robobun 2b62cc1
Blob: one check for a file that could not be stat'd
robobun ffd326d
test: pin each reader of a handle that was asked while its file was m…
robobun 4f37781
Merge origin/main into farm/e27dc7cb/bunfile-failed-stat-not-cached
robobun da20114
Merge origin/main into farm/e27dc7cb/bunfile-failed-stat-not-cached
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.