Skip to content

Report unmapped Windows syscall errors with code "UNKNOWN" instead of "EUNKNOWN" - #39340

Closed
robobun wants to merge 1 commit into
mainfrom
farm/3b9b5725/windows-unknown-errno-code
Closed

robobun wants to merge 1 commit into
mainfrom
farm/3b9b5725/windows-unknown-errno-code

errno: name the Windows unknown-errno fallback UNKNOWN like libuv and…

a1d9c3f
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 16, 2026 in 10m 40s

Code review found 1 potential issue

Found 2 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/errno/windows_errno.rs:556-557 Remaining hardcoded "EUNKNOWN" literal in child_process.ts

Annotations

Check warning on line 557 in src/errno/windows_errno.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

Remaining hardcoded "EUNKNOWN" literal in child_process.ts

After this PR, `src/js/node/child_process.ts:1168` becomes the only remaining user-visible `"EUNKNOWN"` literal in the tree — it's passed as the `errno` arg to `SystemError()` in the `#handleOnExit` `exitCode < 0` path, so the emitted error carries `err.errno === "EUNKNOWN"`. It's pre-existing and on a different mechanism (populates `err.errno` as a string, with `err.code = "ERR_CHILD_PROCESS_UNKNOWN_ERROR"`; doesn't touch the `SystemErrno` strum machinery), and the correct fix there is Node's `