Skip to content

bun-types: declare MatchedRoute.scriptSrc - #39278

Closed
robobun wants to merge 1 commit into
mainfrom
farm/372b2e72/fsrouter-scriptsrc-types
Closed

robobun wants to merge 1 commit into
mainfrom
farm/372b2e72/fsrouter-scriptsrc-types

bun-types: declare MatchedRoute.scriptSrc

2a48b0e
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 16, 2026 in 11m 21s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/integration/bun-types/fixture/fsrouter.ts:11-13 PR description claims bun-types.test.ts changes that were not committed

Annotations

Check warning on line 13 in test/integration/bun-types/fixture/fsrouter.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

PR description claims bun-types.test.ts changes that were not committed

The PR description says `bun-types.test.ts` gains a `Bun.FileSystemRouter` case with a shared `tsc`-spawning helper, and that `bun bd test` fails/passes on that new case — but the diff only touches `bun.d.ts` and `fixture/fsrouter.ts`; `bun-types.test.ts` is unchanged. The shipped fixture coverage is fine per the CLAUDE.md bun-types exception, so this is description-accuracy only: either drop the `bun-types.test.ts` paragraph from the description, or commit the described test case.