-
Notifications
You must be signed in to change notification settings - Fork 5.1k
ast: name BabyString::r#in's parameters for what they are #39137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+8
−7
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| [bun_ast] | ||
| "arg_named_like_other_param:src/ast/lib.rs" = 1 | ||
| "bare_bool_args:src/ast/lib.rs" = 1 | ||
|
|
||
| [bun_bundler] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1077,15 +1077,17 @@ impl BabyString { | |
| (self.0 >> 16) as u16 | ||
| } | ||
|
|
||
| pub fn r#in(parent: &[u8], text: &[u8]) -> BabyString { | ||
| /// Locates `substring` inside `container` (the string later passed to | ||
| /// [`BabyString::slice`]) and records its offset and length. | ||
| pub fn r#in(container: &[u8], substring: &[u8]) -> BabyString { | ||
| // bun_core::strings::index_of deliberately returns None for an empty | ||
| // needle, but an empty `text` reaches this path via resolve errors for | ||
| // `import ""`, so short-circuit it here to offset 0. | ||
| if text.is_empty() { | ||
| // needle, but an empty `substring` reaches this path via resolve errors | ||
| // for `import ""`, so short-circuit it here to offset 0. | ||
|
Comment on lines
+1084
to
+1085
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code |
||
| if substring.is_empty() { | ||
| return BabyString::new(0, 0); | ||
| } | ||
| let off = bun_core::strings::index_of(parent, text).expect("unreachable"); | ||
| BabyString::new(off as u16, text.len() as u16) // @truncate | ||
| let off = bun_core::strings::index_of(container, substring).expect("unreachable"); | ||
| BabyString::new(off as u16, substring.len() as u16) // @truncate | ||
| } | ||
|
|
||
| pub fn slice<'a>(self, container: &'a [u8]) -> &'a [u8] { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code