Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mordant-baseline.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[bun_ast]
"arg_named_like_other_param:src/ast/lib.rs" = 1
"bare_bool_args:src/ast/lib.rs" = 1

[bun_bundler]
Expand Down
14 changes: 8 additions & 6 deletions src/ast/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1077,15 +1077,17 @@ impl BabyString {
(self.0 >> 16) as u16
}

pub fn r#in(parent: &[u8], text: &[u8]) -> BabyString {
/// Locates `substring` inside `container` (the string later passed to
/// [`BabyString::slice`]) and records its offset and length.
Comment on lines +1080 to +1081

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code

pub fn r#in(container: &[u8], substring: &[u8]) -> BabyString {
// bun_core::strings::index_of deliberately returns None for an empty
// needle, but an empty `text` reaches this path via resolve errors for
// `import ""`, so short-circuit it here to offset 0.
if text.is_empty() {
// needle, but an empty `substring` reaches this path via resolve errors
// for `import ""`, so short-circuit it here to offset 0.
Comment on lines +1084 to +1085

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code

if substring.is_empty() {
return BabyString::new(0, 0);
}
let off = bun_core::strings::index_of(parent, text).expect("unreachable");
BabyString::new(off as u16, text.len() as u16) // @truncate
let off = bun_core::strings::index_of(container, substring).expect("unreachable");
BabyString::new(off as u16, substring.len() as u16) // @truncate
}

pub fn slice<'a>(self, container: &'a [u8]) -> &'a [u8] {
Expand Down
Loading