Skip to content

node:http2: throw getUnpackedSettings/respondWithFD ERR_INVALID_ARG_TYPE through the shared error machinery - #38644

Closed
robobun wants to merge 2 commits into
mainfrom
farm/0b34c2d2/http2-invalid-arg-type-shared-renderer
Closed

robobun wants to merge 2 commits into
mainfrom
farm/0b34c2d2/http2-invalid-arg-type-shared-renderer

node:http2: build getUnpackedSettings/respondWithFD ERR_INVALID_ARG_T…

a94feb5
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Aug 14, 2026 in 9m 0s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/js/node/http2/node-http2.test.js:4132 Second await on req 'end' has no error path wired to reject

Annotations

Check warning on line 4132 in test/js/node/http2/node-http2.test.js

See this annotation in the file changed.

@claude claude / Claude Code Review

Second await on req 'end' has no error path wired to reject

The second await only wires `resolve` — `req.on("error", reject)` at line 4125 belongs to the first promise, which has already settled on `response`, so a mid-body stream error here is a no-op reject and this await hangs until the runner timeout instead of failing with the actual error. Wire the failure path: `await new Promise((resolve, reject) => { req.on("end", resolve); req.on("error", reject); })`.