Repository navigation
node:http2: let tls.Server wrap a socket injected into an Http2SecureServer #38124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a45ac59
node:http2: report an injected socket's error on the session instead …
robobun 1ad82ac
node:http2: report a failed injected-connection upgrade on the server…
robobun 28a41ae
node:http2: shorten the upgrade error comments
robobun 24c2e18
node:http2: one-line comments in the upgrade error paths
robobun 0321e26
node:http2: assert the forwarded error is the same object
robobun dffc03a
Merge branch 'main' into farm/704a033b/http2-upgrade-raw-socket-error
robobun 8c593be
node:http2: report an injected socket's error before the handover as …
robobun 47073a0
node:http2: let tls.Server wrap a socket injected into an Http2Secure…
robobun 7123397
test: the socket injected into an Http2SecureServer reaches the sessi…
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.