Repository navigation
node:http2: send array-valued pushStream() headers as one field per element - #37579
Merged
Jarred-Sumner merged 5 commits intoAug 11, 2026
Merged
Claude / Claude Code Review
completed
Aug 11, 2026 in 13m 15s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/js/node/http2/node-http2.test.js:3597-3625 |
pushedHeaderBlocks helper leaks client session on error path |
Annotations
Check warning on line 3625 in test/js/node/http2/node-http2.test.js
claude / Claude Code Review
pushedHeaderBlocks helper leaks client session on error path
The `pushedHeaderBlocks` helper only calls `client.close()` on the happy path (after `await promise`); if any of the wired `reject` handlers fires, control jumps to the `finally`, which closes only the server — and `server.close()` does not terminate live connections, so the h2 client session and its socket leak. Consider hoisting `let client;` above the `try` and adding `client?.close();` to the `finally`, or wrapping the client in a nested `try/finally`. (Nit — only bites when the test is alre
Loading