Repository navigation
Remove dead code from webcore HTTP/timing C++ and install::dependency - #36621
Merged
Jarred-Sumner merged 5 commits intoAug 2, 2026
Merged
Jarred-Sumner merged 5 commits into
Jarred-Sumner merged 5 commits into
Claude / Claude Code Review
completed
Aug 2, 2026 in 12m 51s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/jsc/bindings/webcore/ResourceTiming.h:47-48 |
Dead forward declarations left in ResourceTiming.h |
Annotations
Check warning on line 48 in src/jsc/bindings/webcore/ResourceTiming.h
claude / Claude Code Review
Dead forward declarations left in ResourceTiming.h
Deleting the commented-out `fromMemoryCache`/`fromLoad`/`fromSynchronousLoad`/`updateExposure` stubs removes the last textual references to `CachedResource`, `ResourceResponse`, and `SecurityOrigin` in this header — the forward declarations at lines 36/38/40 are now orphaned. Same pattern as the `CrossThreadCopier.h` include already dropped from `HTTPHeaderMap.cpp` in e90ebae3; drop these three too (`PerformanceServerTiming` and `ResourceLoadTiming` are still used and should stay).
Loading