Skip to content

test(net): drop 100ms setTimeout race from the net.Server listen tests #36310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 3 commits into from
Jul 29, 2026
Merged

test(net): drop 100ms setTimeout race from the net.Server listen tests #36310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e126486
test(net): drop 100ms setTimeout race from net.Server listen tests
robobun Jul 29, 2026
7ffe330
trim failOnError comment to the durable part
robobun Jul 29, 2026
6b920f8
ci: retrigger
robobun Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 25 additions & 92 deletions test/js/node/net/node-net-server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,18 @@ describe("net.createServer listen", () => {
done();
});

// No secondary setTimeout deadline: the test runner already bounds each test,
// and a real listen failure reaches done() via the 'error' listener below.
const failOnError = (server: Server, done: (err?: unknown) => void) => (err: unknown) => {
server.close();
done(err);
};

it("should listen on IPv6 by default", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();
let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
0,
Expand All @@ -46,18 +46,10 @@ describe("net.createServer listen", () => {
});

it("should listen on IPv4", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
0,
Expand All @@ -75,73 +67,45 @@ describe("net.createServer listen", () => {
});

it("should call listening", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};

server.on("error", closeAndFail).on(
server.on("error", failOnError(server, done)).on(
"listening",
mustCall(() => {
clearTimeout(timeout);
server.close();
done();
}),
);

timeout = setTimeout(closeAndFail, 100);

server.listen(0, "0.0.0.0");
});

it("should provide listening property", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();
expect(server.listening).toBeFalse();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};

server.on("error", closeAndFail).on(
server.on("error", failOnError(server, done)).on(
"listening",
mustCall(() => {
expect(server.listening).toBeTrue();
clearTimeout(timeout);
server.close();
expect(server.listening).toBeFalse();
done();
}),
);

timeout = setTimeout(closeAndFail, 100);

server.listen(0, "0.0.0.0");
});

it("should listen on localhost", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
0,
Expand All @@ -159,18 +123,10 @@ describe("net.createServer listen", () => {
});

it("should listen on localhost", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
0,
Expand All @@ -186,18 +142,10 @@ describe("net.createServer listen", () => {
});

it("should listen without port or host", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
mustCall(() => {
Expand All @@ -213,18 +161,10 @@ describe("net.createServer listen", () => {
});

it("should listen on unix domain socket", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();

let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
socket_domain,
Expand All @@ -238,17 +178,10 @@ describe("net.createServer listen", () => {
});

it("should bind IPv4 0.0.0.0 when listen on 0.0.0.0, issue#7355", done => {
const { mustCall, mustNotCall } = createCallCheckCtx(done);
const { mustCall } = createCallCheckCtx(done);

const server: Server = createServer();
let timeout: Timer;
const closeAndFail = () => {
clearTimeout(timeout);
server.close();
mustNotCall()();
};
server.on("error", closeAndFail);
timeout = setTimeout(closeAndFail, 100);
server.on("error", failOnError(server, done));

server.listen(
0,
Expand Down
Loading