Repository navigation
codegen: lay out builtin module sources in dependency order - #36101
Merged
Merged
Claude / Claude Code Review
completed
Jul 27, 2026 in 13m 40s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | src/codegen/bundle-modules.ts:327 |
Dead hotRoots entry: node/buffer.ts is a native module |
Annotations
Check warning on line 327 in src/codegen/bundle-modules.ts
claude / Claude Code Review
Dead hotRoots entry: node/buffer.ts is a native module
`"node/buffer.ts"` is dead here — `node:buffer` is a native module (declared in `src/jsc/modules/_NativeModule.h`), not a JS builtin under `src/js/node/`, so it never appears in `moduleList.slice(0, nativeStartIndex)` and `deps.has("node/buffer.ts")` is always false. The `.filter(r => deps.has(r))` on line 334 silently drops it so nothing breaks, but per the "every line you add must be demonstrably live" rule this entry should be removed.
Loading