test: module-hooks inline-typescript tests + upstream TS fixture (+4 tests) - #35695
Draft
cirospaciari wants to merge 8 commits into
Draft
cirospaciari wants to merge 8 commits into
cirospaciari wants to merge 8 commits into
Conversation
…eam TypeScript fixture The four inline-typescript module-hooks tests exercise registerHooks-driven TypeScript transpilation. They need upstream's bundled TypeScript compiler fixture (test/fixtures/snapshot/typescript.js, 10.5MB, vendored byte-verbatim).
Contributor
|
Found 3 issues this PR may fix:
🤖 Generated with Claude Code |
Collaborator
…to claude/node-module-hooks-ts No-Verification-Needed: automatic base-branch sync merge, no hand-authored changes
…to claude/node-module-hooks-ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/fixtures/snapshot/typescript.js— a 10.5MB text fixture (the bundled TypeScript compiler) — byte-verbatim. It is what Node's own suite ships; the 4 vendoredmodule-hooksinline-typescript tests chainregisterHooks(landed in #35690) through it. If 10.5MB in-repo is unacceptable, the alternative is generating/downloading it at test time, which trades hermeticity.require+importvariants, with and without override)test-module-hooks-preload.jsdeliberately NOT vendored: Bun transpiles the.ctsentry natively before the registered hook sees it, so the hook's output never reaches stdout — a real registerHooks-vs-native-loader precedence edge, noted for the node:module: implement synchronous module.registerHooks() (+49 tests) #35690 follow-up