Skip to content

parser: reject parameter decorators without experimentalDecorators - #35544

Closed
robobun wants to merge 5 commits into
mainfrom
farm/e1e3e8c6/reject-param-decorators-without-experimental
Closed

robobun wants to merge 5 commits into
mainfrom
farm/e1e3e8c6/reject-param-decorators-without-experimental

ci: retrigger

eccf9e3
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 25, 2026 in 16m 27s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing src/js_parser/parse/parse_fn.rs:246-251 tsconfig extends chain drops experimentalDecorators — new error's hint can mislead (pre-existing resolver bug)

Annotations

Check notice on line 251 in src/js_parser/parse/parse_fn.rs

See this annotation in the file changed.

@claude claude / Claude Code Review

tsconfig extends chain drops experimentalDecorators — new error's hint can mislead (pre-existing resolver bug)

Heads-up on a pre-existing resolver bug this error will surface more loudly: the tsconfig `extends`-chain merge (`src/resolver/resolver.rs:6404-6449`) never propagates `experimental_decorators` from child configs into the merged config — it OR-merges `emit_decorator_metadata` (line 6409) but has no corresponding line for `experimental_decorators`. So a project whose leaf `tsconfig.json` sets `"experimentalDecorators": true` while extending a base that omits it will now get this new error with a