Skip to content

bun init: put typescript in devDependencies, not peerDependencies #35445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bun init: put typescript in devDependencies, not peerDependencies #35445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
258cd2d
bun init: put typescript in devDependencies, not peerDependencies
robobun Jul 24, 2026
9f1fad9
docs: update quickstart package.json to match new init output
robobun Jul 24, 2026
ea756e3
ci: retrigger
robobun Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions docs/quickstart.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,7 @@ Bun can also execute `"scripts"` from your `package.json`. Add the following scr
"start": "bun run index.ts" // [!code ++]
}, // [!code ++]
"devDependencies": {
"@types/bun": "latest"
},
"peerDependencies": {
"@types/bun": "latest",
"typescript": "^6"
}
}
Expand Down
2 changes: 0 additions & 2 deletions src/runtime/cli/init/react-app/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions src/runtime/cli/init/react-app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
"devDependencies": {
"@types/react": "^19",
"@types/react-dom": "^19",
"@types/bun": "latest"
},
"peerDependencies": {
"@types/bun": "latest",
"typescript": "^6"
}
}
2 changes: 0 additions & 2 deletions src/runtime/cli/init/react-shadcn/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions src/runtime/cli/init/react-shadcn/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@
"@types/react": "^19",
"@types/react-dom": "^19",
"@types/bun": "latest",
"tailwindcss": "^4.1.11"
},
"peerDependencies": {
"tailwindcss": "^4.1.11",
"typescript": "^6"
}
}
2 changes: 0 additions & 2 deletions src/runtime/cli/init/react-tailwind/bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions src/runtime/cli/init/react-tailwind/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
"devDependencies": {
"@types/react": "^19",
"@types/react-dom": "^19",
"@types/bun": "latest"
},
"peerDependencies": {
"@types/bun": "latest",
"typescript": "^6"
}
}
6 changes: 3 additions & 3 deletions src/runtime/cli/init_command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,15 +771,15 @@ impl InitCommand {
}

if needs_typescript_dependency {
let mut peer_dependencies = object.get(b"peerDependencies").unwrap_or_else(|| {
let mut dev_dependencies = object.get(b"devDependencies").unwrap_or_else(|| {
bun_ast::Expr::init(bun_ast::E::Object::default(), bun_ast::Loc::EMPTY)
});
peer_dependencies.data.e_object_mut().unwrap().put_string(
dev_dependencies.data.e_object_mut().unwrap().put_string(
&bump,
b"typescript",
b"^6",
)?;
object.put(&bump, b"peerDependencies", peer_dependencies)?;
object.put(&bump, b"devDependencies", dev_dependencies)?;
}
}

Expand Down
15 changes: 7 additions & 8 deletions test/cli/init/init.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ const initEnv = { ...bunEnv, BUN_AGENT_RULE_DISABLED: "1" };
"private": true,
"devDependencies": {
"@types/bun": "latest",
},
"peerDependencies": {
"typescript": "^6",
},
});
Expand Down Expand Up @@ -222,12 +220,10 @@ const initEnv = { ...bunEnv, BUN_AGENT_RULE_DISABLED: "1" };
{
"devDependencies": {
"@types/bun": "latest",
"typescript": "^6",
},
"module": "index.ts",
"name": "my edited package.json",
"peerDependencies": {
"typescript": "^6",
},
"private": true,
"type": "module",
}
Expand All @@ -254,7 +250,8 @@ const initEnv = { ...bunEnv, BUN_AGENT_RULE_DISABLED: "1" };
expect(pkg).toHaveProperty("dependencies.react-dom");
expect(pkg).toHaveProperty("devDependencies.@types/react");
expect(pkg).toHaveProperty("devDependencies.@types/react-dom");
expect(pkg.peerDependencies).toEqual({ typescript: "^6" });
expect(pkg).toHaveProperty("devDependencies.typescript", "^6");
expect(pkg.peerDependencies).toBeUndefined();

expect(fs.existsSync(path.join(temp, "src"))).toBe(true);
expect(fs.existsSync(path.join(temp, "src/index.ts"))).toBe(true);
Expand All @@ -279,7 +276,8 @@ const initEnv = { ...bunEnv, BUN_AGENT_RULE_DISABLED: "1" };
expect(pkg).toHaveProperty("devDependencies.@types/react");
expect(pkg).toHaveProperty("devDependencies.@types/react-dom");
expect(pkg).toHaveProperty("dependencies.bun-plugin-tailwind");
expect(pkg.peerDependencies).toEqual({ typescript: "^6" });
expect(pkg).toHaveProperty("devDependencies.typescript", "^6");
expect(pkg.peerDependencies).toBeUndefined();

expect(fs.existsSync(path.join(temp, "src"))).toBe(true);
expect(fs.existsSync(path.join(temp, "src/index.ts"))).toBe(true);
Expand All @@ -304,7 +302,8 @@ const initEnv = { ...bunEnv, BUN_AGENT_RULE_DISABLED: "1" };
expect(pkg).toHaveProperty("dependencies.class-variance-authority");
expect(pkg).toHaveProperty("dependencies.clsx");
expect(pkg).toHaveProperty("dependencies.bun-plugin-tailwind");
expect(pkg.peerDependencies).toEqual({ typescript: "^6" });
expect(pkg).toHaveProperty("devDependencies.typescript", "^6");
expect(pkg.peerDependencies).toBeUndefined();

expect(fs.existsSync(path.join(temp, "src"))).toBe(true);
expect(fs.existsSync(path.join(temp, "src/index.ts"))).toBe(true);
Expand Down
Loading