test: restore 6 hand-weakened vendored tests and fix the compat bugs they hid

src/cares_sys/c_ares.rs

@@ -751,11 +751,18 @@ impl Channel {
             sock_state_cb_data: std::ptr::from_ref::<C>(this).cast_mut().cast::<c_void>(),
             timeout: options.timeout.unwrap_or(-1),
             tries: options.tries.unwrap_or(4),
+            // Node turns c-ares' answer cache off (its default max TTL is one
+            // hour), so a resolver in Bun must not serve stale answers either.
+            // https://github.com/nodejs/node/blob/v26.3.0/src/cares_wrap.cc#L897
+            qcache_max_ttl: 0,
             ..Default::default()
         };
 
-        let optmask: c_int =
-            ARES_OPT_FLAGS | ARES_OPT_TIMEOUTMS | ARES_OPT_SOCK_STATE_CB | ARES_OPT_TRIES;
+        let optmask: c_int = ARES_OPT_FLAGS
+            | ARES_OPT_TIMEOUTMS
+            | ARES_OPT_SOCK_STATE_CB
+            | ARES_OPT_TRIES
+            | ARES_OPT_QUERY_CACHE;
 
         // SAFETY: idempotent Winsock init (uv_once); c-ares creates its sockets with
         // ws2_32 directly and libuv otherwise initializes Winsock lazily.
@@ -1817,6 +1824,7 @@ pub(crate) const ARES_OPT_FLAGS: c_int = 1 << 0;
 pub(crate) const ARES_OPT_TRIES: c_int = 1 << 2;
 pub(crate) const ARES_OPT_SOCK_STATE_CB: c_int = 1 << 9;
 pub(crate) const ARES_OPT_TIMEOUTMS: c_int = 1 << 13;
+pub(crate) const ARES_OPT_QUERY_CACHE: c_int = 1 << 21;
 pub(crate) const ARES_NI_NAMEREQD: c_int = 1 << 2;
 pub(crate) const ARES_NI_LOOKUPHOST: c_int = 1 << 8;
 pub(crate) const ARES_NI_LOOKUPSERVICE: c_int = 1 << 9;

src/js/internal-for-testing.ts

@@ -1,11 +1,7 @@
 // Hardcoded module "bun:internal-for-testing"
 
-// If you want to test an internal API, add a binding into this file.
-//
-// Then at test time: import ... from "bun:internal-for-testing"
-//
-// In a debug build, the import is always allowed.
-// It is disallowed in release builds unless run in Bun's CI.
+// Add bindings for internal APIs here and `import ... from "bun:internal-for-testing"`.
+// Always allowed in debug builds; in release builds only under Bun's CI.
 
 const fmtBinding = $bindgenFn("fmt_jsc.bind.ts", "fmtString");
 
@@ -169,10 +165,9 @@ export const setSyntheticAllocationLimitForTesting: (limit: number) => number =
   1,
 );
 
-// Shrink the markdown parser's block-metadata cap (in bytes) so its
-// `TooManyBlocks` error is reachable without 4 GiB of input. The cap can only
-// be lowered, never raised past the real limit. Returns the previous value so
-// a test can restore it.
+// Lower the markdown parser's block-metadata cap (bytes) so `TooManyBlocks` is
+// reachable without 4 GiB of input. Can only lower, never raise past the real
+// limit; returns the previous value so a test can restore it.
 export const setMaxMarkdownBlockBytesForTesting: (limit: number) => number = $newRustFunction(
   "MarkdownObject.rs",
   "setMaxMarkdownBlockBytesForTesting",
@@ -323,6 +318,19 @@ function assignFunctionName(name, fn, descriptor = nodeKEmptyObject) {
   });
 }
 
+// No-op emitter (Bun handles --pending-deprecation natively) but preserves `length`.
+// https://github.com/nodejs/node/blob/v26.3.0/lib/internal/util.js#L204
+function nodePendingDeprecate(fn) {
+  function deprecated(...args) {
+    return fn.$apply(this, args);
+  }
+  Object.defineProperty(deprecated, "length", {
+    __proto__: null,
+    ...Object.getOwnPropertyDescriptor(fn, "length"),
+  });
+  return deprecated;
+}
+
 function nodeIsError(e) {
   return require("node:util/types").isNativeError(e) || e instanceof Error;
 }
@@ -448,18 +456,17 @@ function nodeGetValidStdio(stdio, sync?) {
 
 let cachedInternalChildProcess;
 
-// Userland access to node-internal modules for vendored node tests that
-// declare `// Flags: --expose-internals` (served via the require interceptor
-// in test/js/node/test/common/index.js). Static requires only — the builtin
-// bundler cannot rewrite variable-path requires. Extend the map as more
-// vendored tests need more internals.
+// Node-internal modules for vendored tests with `// Flags: --expose-internals`
+// (served via test/js/node/test/common/index.js). Static requires only — the
+// builtin bundler cannot rewrite variable-path requires.
 export const exposedInternals = {
   "internal/streams/add-abort-signal": require("internal/streams/add-abort-signal"),
   "internal/util/debuglog": require("internal/util/debuglog"),
   "internal/async_context_frame": require("internal/async_context_frame"),
   "internal/async_hooks": require("internal/async_hooks"),
   "internal/webstreams/adapters": require("internal/webstreams_adapters"),
   "internal/dgram": require("internal/dgram"),
+  "internal/timers": require("internal/timers"),
   // Bun's real implementations, under the names node's tests import them by.
   "internal/validators": require("internal/validators"),
   "internal/util/inspect": require("internal/util/inspect"),
@@ -479,6 +486,7 @@ export const exposedInternals = {
     assertCrypto() {},
     getCIDR,
     isError: nodeIsError,
+    pendingDeprecate: nodePendingDeprecate,
     assignFunctionName,
     kEnumerableProperty: Object.freeze({ __proto__: null, enumerable: true }),
     kEmptyObject: nodeKEmptyObject,
@@ -502,6 +510,10 @@ export const exposedInternals = {
       getValidStdio: nodeGetValidStdio,
     });
   },
+  // translatePeerCertificate lives in node:_tls_common in Bun; upstream keeps
+  // the implementation in internal/tls/common and re-exports it from
+  // _tls_common, which is where node's tests import it from.
+  "internal/tls/common": require("internal/tls/common"),
   "internal/fs/utils": {
     // Both are the REAL parsers the fs entry points use (FileSystemFlags::from_js
     // and args::Rm::from_js), not JS reimplementations -- vendored tests assert
@@ -513,12 +525,9 @@ export const exposedInternals = {
   // module (src/js/internal/test/binding.ts), not from here.
 };
 
-// State of a web ReadableStream/WritableStream for vendored node tests that
-// read Node's `stream[kState].state` / `.storedError` (served through the
-// internal/webstreams/util shim in test/js/node/test/common/index.js).
-// The stream's closed promise is settled from every terminal transition, so its
-// status is the state. A WritableStream mid-`erroring` still reports "writable":
-// erroring is not terminal, and nothing observable distinguishes the two here.
+// Web stream state for vendored node tests that read `stream[kState].state`.
+// The closed promise's status is the state; a mid-`erroring` WritableStream
+// reports "writable" (erroring is non-terminal, nothing observable differs).
 export function getWebStreamState(stream: ReadableStream | WritableStream): {
   state: string;
   storedError: unknown;

src/js/internal/timers.ts

@@ -1,4 +1,4 @@
-const { validateNumber } = require("internal/validators");
+const { validateFunction, validateNumber } = require("internal/validators");
 
 const NumberIsFinite = Number.isFinite;
 
@@ -22,11 +22,35 @@ function getTimerDuration(msecs, name) {
   return msecs;
 }
 
+// node's internal helper for timers that must not hold the event loop open.
+// https://github.com/nodejs/node/blob/v26.3.0/lib/internal/timers.js#L370
+function setUnrefTimeout(callback, after, arg1, arg2, arg3) {
+  validateFunction(callback, "callback");
+
+  let timer;
+  switch (arguments.length) {
+    case 1:
+    case 2:
+      timer = setTimeout(callback, after);
+      break;
+    case 3:
+      timer = setTimeout(callback, after, arg1);
+      break;
+    case 4:
+      timer = setTimeout(callback, after, arg1, arg2);
+      break;
+    default:
+      timer = setTimeout(callback, after, arg1, arg2, arg3);
+      break;
+  }
+  return timer.unref();
+}
+
 export default {
-  // For hiding Timeouts on other internals. A registered symbol so the node
-  // test harness's --expose-internals shim ("internal/timers" virtual module
-  // in test/js/node/test/common/index.js) can hand the same symbol to ported
-  // tests that inspect socket[kTimeout].
+  TIMEOUT_MAX,
+  // Registered symbol so the --expose-internals shim (test/js/node/test/common/index.js)
+  // hands the same symbol to ported tests that inspect socket[kTimeout].
   kTimeout: Symbol.for("::buntimeout::"),
   getTimerDuration,
+  setUnrefTimeout,
 };

src/js/internal/tls/common.ts

@@ -0,0 +1,30 @@
+// Translate some fields from the handle's C-friendly format into more idiomatic
+// javascript object representations before passing them back to the user.  Can
+// be used on any cert object, but changing the name would be semver-major.
+function translatePeerCertificate(c) {
+  if (!c) return null;
+
+  if (c.issuerCertificate != null && c.issuerCertificate !== c) {
+    c.issuerCertificate = translatePeerCertificate(c.issuerCertificate);
+  }
+  if (c.infoAccess != null) {
+    const info = c.infoAccess;
+    const parsed = (c.infoAccess = Object.create(null));
+
+    // XXX: More key validation?
+    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, (all, key, val) => {
+      if (val.charCodeAt(0) === 0x22) {
+        // Only used on internally created legacy cert objects; quoted values
+        // are always valid JSON string literals, so this never throws.
+        val = JSON.parse(val);
+      }
+      if (key in parsed) parsed[key].push(val);
+      else parsed[key] = [val];
+    });
+  }
+  return c;
+}
+
+export default {
+  translatePeerCertificate,
+};

src/js/internal/util/deprecate.ts

@@ -19,7 +19,10 @@ function getDeprecationWarningEmitter(code, msg, deprecated, shouldEmitWarning =
   };
 }
 
-function deprecate(fn, msg, code) {
+// `modifyPrototype` mirrors node's internal deprecate() parameter of the same
+// name, surfaced publicly as util.deprecate(fn, msg, code, { modifyPrototype }).
+// https://github.com/nodejs/node/blob/v26.3.0/lib/internal/util.js#L162
+function deprecate(fn, msg, code, modifyPrototype = true) {
   // Lazy-load to avoid a circular dependency.
   if (code !== undefined) validateString(code, "code");
 
@@ -35,23 +38,42 @@ function deprecate(fn, msg, code) {
     return fn.$apply(this, args);
   }
 
-  // The wrapper will keep the same prototype as fn to maintain prototype chain
-  Object.setPrototypeOf(deprecated, fn);
-  const fnPrototype = fn.prototype;
-  if (fnPrototype) {
-    // Sharing fn.prototype makes instanceof work across the wrapper. Use defineProperty:
-    // builtin-compiled wrappers lack an own "prototype", so a plain assignment would hit
-    // fn's non-writable "prototype" through the prototype chain.
-    Object.defineProperty(deprecated, "prototype", {
+  // Bun compiles builtin modules such that function declarations get no own
+  // "prototype" property; node's wrapper is a plain function declaration, so
+  // give it the same default shape before applying node's prototype handling.
+  Object.defineProperty(deprecated, "prototype", {
+    __proto__: null,
+    value: Object.defineProperty({}, "constructor", {
       __proto__: null,
-      value: fnPrototype,
+      value: deprecated,
       writable: true,
+      enumerable: false,
+      configurable: true,
+    }),
+    writable: true,
+    enumerable: false,
+    configurable: false,
+  });
+
+  if (modifyPrototype) {
+    // The wrapper will keep the same prototype as fn to maintain prototype chain
+    Object.setPrototypeOf(deprecated, fn);
+    const fnPrototype = fn.prototype;
+    if (fnPrototype) {
+      // Sharing fn.prototype makes instanceof work across the wrapper. Use defineProperty:
+      // builtin-compiled wrappers lack an own "prototype", so a plain assignment would hit
+      // fn's non-writable "prototype" through the prototype chain.
+      Object.defineProperty(deprecated, "prototype", {
+        __proto__: null,
+        value: fnPrototype,
+        writable: true,
+      });
+    }
+    Object.defineProperty(deprecated, "length", {
+      __proto__: null,
+      ...Object.getOwnPropertyDescriptor(fn, "length"),
     });
   }
-  Object.defineProperty(deprecated, "length", {
-    __proto__: null,
-    ...Object.getOwnPropertyDescriptor(fn, "length"),
-  });
   return deprecated;
 }
 

src/js/node/_tls_common.ts

@@ -1,40 +1,11 @@
 // Hardcoded module "node:_tls_common"
-// Deprecated shim mirroring node's lib/_tls_common.js: re-exports the real
-// implementations and warns on load.
+// Deprecated shim: re-exports the real impls and warns on load.
 // https://github.com/nodejs/node/blob/v26.3.0/lib/_tls_common.js
 const { SecureContext, createSecureContext } = require("node:tls");
 
 process.emitWarning("The _tls_common module is deprecated. Use `node:tls` instead.", "DeprecationWarning", "DEP0192");
 
-// Translate some fields from the handle's C-friendly format into more idiomatic
-// javascript object representations before passing them back to the user.  Can
-// be used on any cert object, but changing the name would be semver-major.
-function translatePeerCertificate(c) {
-  if (!c) return null;
-
-  if (c.issuerCertificate != null && c.issuerCertificate !== c) {
-    c.issuerCertificate = translatePeerCertificate(c.issuerCertificate);
-  }
-  if (c.infoAccess != null) {
-    const info = c.infoAccess;
-    const parsed = (c.infoAccess = Object.create(null));
-
-    // XXX: More key validation?
-    info.replace(/([^\n:]*):([^\n]*)(?:\n|$)/g, (all, key, val) => {
-      if (val.charCodeAt(0) === 0x22) {
-        // The translatePeerCertificate function is only
-        // used on internally created legacy certificate
-        // objects, and any value that contains a quote
-        // will always be a valid JSON string literal,
-        // so this should never throw.
-        val = JSON.parse(val);
-      }
-      if (key in parsed) parsed[key].push(val);
-      else parsed[key] = [val];
-    });
-  }
-  return c;
-}
+const { translatePeerCertificate } = require("internal/tls/common");
 
 export default {
   SecureContext,