Repository navigation
spawn(windows): release StaticPipeWriter start() ref when buffer-stdin write completes - #35297
Merged
Merged
Claude / Claude Code Review
completed
Jul 23, 2026 in 17m 7s
Code review found 1 important issue
Found 3 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/spawn/static_pipe_writer.rs:287-292 |
Test file, fixture, and LIVE_COUNT instrumentation dropped from the squashed commit |
Annotations
Check failure on line 292 in src/spawn/static_pipe_writer.rs
claude / Claude Code Review
Test file, fixture, and LIVE_COUNT instrumentation dropped from the squashed commit
The test file (`test/js/bun/spawn/spawn-buffer-stdin-leak.test.ts` + fixture), the `LIVE_COUNT` atomic in `StaticPipeWriter::create`/`Drop`, and the `subprocessInternals.staticPipeWriterLiveCount()` hook in `bun:internal-for-testing` — all described in the PR body's Verification section and iterated on through ddf245e1 — were dropped in the squash to 87ce1585; the diff now touches only three `.rs` files. REVIEW.md requires a leak regression test in the same PR ("UAF/leak fixes need an ASan repro
Loading