Skip to content

test(shell): align brace.test.ts nested-empty-variant cases with bash-5.2 literal {} #34882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 2 commits into from
Jul 21, 2026
Merged

test(shell): align brace.test.ts nested-empty-variant cases with bash-5.2 literal {} #34882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d582d9b
test(shell): align brace.test.ts nested-empty-variant cases with bash…
robobun Jul 21, 2026
0ecd8eb
move {{a,}{b,}} to the comma-less-is-literal block
robobun Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions test/js/bun/shell/brace.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,7 @@ describe("$.braces", () => {
["{x,{a,,b}}", ["x", "a", "", "b"]],
["{x,{a,b,}}", ["x", "a", "b", ""]],
["{{a,},x}", ["a", "", "x"]],
["{{a,}{b,}}", ["ab", "a", "b", ""]],
["p{q,{r,}{s,}}t", ["pqt", "prst", "prt", "pst", "pt"]],
// A nested comma-free `{}` previously parsed to 0 variants, which made
// expand_nested return early and drop the text after it. It is now 1
// empty variant, matching calculate_expanded_amount and expand_flat.
["{x,a{}b}", ["x", "ab"]],
["{a,b{}}c", ["ac", "bc"]],
["{x,{}y}", ["x", "y"]],
])("%s", (pattern, expected) => {
expect($.braces(pattern)).toEqual(expected);
});
Expand Down Expand Up @@ -222,6 +215,7 @@ describe("comma-less brace group is literal (bash 5.2)", () => {
// `{foo}` with no comma is literal at any depth.
["{a,{b}}", ["a", "{b}"]],
["{a{b,c}}", ["{ab}", "{ac}"]],
["{{a,}{b,}}", ["{ab}", "{a}", "{b}", "{}"]],
// A comma outside every `{...}` does not make one expand.
["{foo},x", ["{foo},x"]],
["{a},{b}", ["{a},{b}"]],
Expand Down
Loading