Repository navigation
webcrypto: ML-DSA + ML-KEM, ChaCha20-Poly1305, raw-secret/raw-public, toCryptoKey, v26 SubtleCrypto surface (+10 tests, webcrypto 58%→76%) #34838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 47 commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
c011038
webcrypto: match Node v26.3.0 error semantics and KeyUsage ordering
cirospaciari 0100ab7
[autofix.ci] apply automated fixes
autofix-ci[bot] 0ac6582
webcrypto: report Node's import and derive errors, drop the non-stand…
cirospaciari 19a7b0d
[autofix.ci] apply automated fixes
autofix-ci[bot] 18aadc0
test(fetch): fill body fixtures through a Uint8Array view
cirospaciari facf342
wasi: random_get should fill the requested window, not all of linear …
cirospaciari 2ec69d0
wasi: random_get returns WASI_ESUCCESS, not bufLen
robobun 968a771
Merge remote-tracking branch 'origin/main' into claude/webcrypto-node…
robobun 31add41
style: trim two new comments to 3 lines
robobun 2a5f4d7
webcrypto: check the throw scope after normalizeCryptoAlgorithmParame…
robobun a6ce715
webcrypto: hold a RefPtr across remove-then-reject in the wrapKey cal…
robobun 39645f9
test: trim exception-scope describe comment to 3 lines
robobun cd10a4a
webcrypto: report key-type mismatch for OKP cross-curve imports
robobun 22ec506
[autofix.ci] apply automated fixes
autofix-ci[bot] f2d7540
webcrypto: carry Node's empty-usages message to sibling sites, report…
robobun 5e68bc0
[autofix.ci] apply automated fixes
autofix-ci[bot] 4082e03
webcrypto: carry ECDH's 'key algorithm mismatch' to X25519 deriveBits
robobun a5e6385
[autofix.ci] apply automated fixes
autofix-ci[bot] 9cb0754
webcrypto: carry 'Unsupported key usage' to RSA importKey, fix RSAES …
robobun 066c563
[autofix.ci] apply automated fixes
autofix-ci[bot] 781f06f
webcrypto: use 'an' before ECDSA/ECDH/Ed25519/X25519 in usage messages
robobun e239db7
webcrypto: add ChaCha20-Poly1305 and the raw-secret key format
cirospaciari a0e449c
[autofix.ci] apply automated fixes
autofix-ci[bot] 06eb822
webcrypto: vendor test-webcrypto-cryptokey-hidden-slots from Node v26…
cirospaciari ad82e7a
test: quarantine worker-terminate ASAN crashes, matching main
cirospaciari cd20e69
test: widen mimalloc page-count bound for JSC heap noise, matching main
cirospaciari a47bc95
webcrypto: add ML-DSA and ML-KEM, the v26 SubtleCrypto surface, and K…
cirospaciari 62fb33f
[autofix.ci] apply automated fixes
autofix-ci[bot] 1cde5be
crypto: avoid bssl::ScopedCBB in marshalAsymmetricKey
cirospaciari ba2e030
crypto: replace remaining bssl::ScopedCBB uses with a shared marshal …
cirospaciari 33d186e
Merge remote-tracking branch 'origin/main' into wt-conflicts-34838
cirospaciari 722e53a
webcrypto: address review findings across the ChaCha20-Poly1305 and A…
cirospaciari 72f1824
[autofix.ci] apply automated fixes
autofix-ci[bot] 897b1aa
webcrypto: drain the AKP error queue in unwrapKey's inner import; mak…
cirospaciari 167c012
webcrypto: dedupe the AKP import/export flows and finish the review r…
cirospaciari 13e9164
webcrypto: share the usage-bitmap mapping with KeyObject; cover every…
cirospaciari 5ce0b8c
webcrypto: test structuredClone DataCloneError and encapsulate result…
cirospaciari 0754ddb
webcrypto: clone-guard test also covers ML-KEM keys
cirospaciari 8c0eca6
webcrypto: node's type error for object keyData; coerce format once
cirospaciari 5a38a32
webcrypto: single-pass HMAC JWK validation with node's member errors
cirospaciari 78d9af6
webcrypto: drop the null-alg arms from the HMAC alg matcher
cirospaciari 18d22af
webcrypto: order wrapKey's extractable check first; node's raw-import…
cirospaciari 2a6b128
[autofix.ci] apply automated fixes
autofix-ci[bot] 0447528
webcrypto: reject duplicate JWK key_ops for ChaCha20 and HMAC
cirospaciari 031b0e2
[autofix.ci] apply automated fixes
autofix-ci[bot] 7d33045
webcrypto: pick the importKey keyData converter by format
cirospaciari 2bd652e
webcrypto: structured clone for ChaCha20-Poly1305 and ML-DSA/ML-KEM keys
cirospaciari 731b81c
webcrypto: clear the BoringSSL queue when deserializing a corrupt AKP…
cirospaciari d894781
webcrypto: pin the undersized-decrypt message for AES-GCM too
cirospaciari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.